Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update spot light visual size #306

Merged
merged 1 commit into from
Apr 16, 2021
Merged

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Apr 16, 2021

Signed-off-by: Ian Chen ichen@osrfoundation.org

馃 Bug fix

Summary

Port spot light visual size fix from gazebosim/gazebo-classic#2947 by @peci1

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@github-actions github-actions bot added 馃彚 edifice Ignition Edifice 馃彲 fortress Ignition Fortress labels Apr 16, 2021
@osrf-triage osrf-triage added this to Inbox in Core development Apr 16, 2021
Core development automation moved this from Inbox to In review Apr 16, 2021
@codecov
Copy link

codecov bot commented Apr 16, 2021

Codecov Report

Merging #306 (f7fd27c) into ign-rendering5 (997512d) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           ign-rendering5     #306   +/-   ##
===============================================
  Coverage           57.52%   57.53%           
===============================================
  Files                 159      159           
  Lines               15589    15589           
===============================================
+ Hits                 8968     8969    +1     
+ Misses               6621     6620    -1     
Impacted Files Coverage 螖
include/ignition/rendering/base/BaseLightVisual.hh 30.09% <0.00%> (酶)
...e/ignition/rendering/base/BaseGaussianNoisePass.hh 100.00% <0.00%> (+3.33%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 997512d...f7fd27c. Read the comment docs.

@ahcorde
Copy link
Contributor

ahcorde commented Apr 16, 2021

The CI warning on Ubuntu is about Optix, not related with this PR

@ahcorde ahcorde merged commit 7b9ac81 into ign-rendering5 Apr 16, 2021
Core development automation moved this from In review to Done Apr 16, 2021
@ahcorde ahcorde deleted the spotlight_visual_size branch April 16, 2021 06:43
@WilliamLewww WilliamLewww linked an issue Apr 19, 2021 that may be closed by this pull request
This was referenced Apr 21, 2021
iche033 added a commit that referenced this pull request Apr 27, 2021
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@j-rivero j-rivero removed this from Done in Core development May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
馃彚 edifice Ignition Edifice 馃彲 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix size of light visual
4 participants