Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clone visuals and geometries #397

Merged
merged 18 commits into from
Sep 22, 2021
Merged

Clone visuals and geometries #397

merged 18 commits into from
Sep 22, 2021

Conversation

adlarkin
Copy link
Contributor

@adlarkin adlarkin commented Sep 8, 2021

Signed-off-by: Ashton Larkin ashton@openrobotics.org

🎉 New feature

Summary

I've added support for cloning visuals and geometries.

Test it

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: Ashton Larkin <ashton@openrobotics.org>
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Sep 8, 2021
@osrf-triage osrf-triage added this to Inbox in Core development Sep 8, 2021
@adlarkin adlarkin mentioned this pull request Sep 8, 2021
8 tasks
@chapulina chapulina moved this from Inbox to In review in Core development Sep 8, 2021
@chapulina chapulina added the beta Targeting beta release of upcoming collection label Sep 8, 2021
Signed-off-by: Ashton Larkin <ashton@openrobotics.org>
Signed-off-by: Ashton Larkin <ashton@openrobotics.org>
src/Visual_TEST.cc Outdated Show resolved Hide resolved
include/ignition/rendering/base/BaseGeometry.hh Outdated Show resolved Hide resolved
adlarkin and others added 2 commits September 14, 2021 12:35
Signed-off-by: Ashton Larkin <ashton@openrobotics.org>
Copy link
Contributor Author

@adlarkin adlarkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iche033 I've got a few comments/questions for you when you get the chance to take a look at this

include/ignition/rendering/base/BaseGeometry.hh Outdated Show resolved Hide resolved
include/ignition/rendering/base/BaseGeometry.hh Outdated Show resolved Hide resolved
include/ignition/rendering/base/BaseVisual.hh Outdated Show resolved Hide resolved
include/ignition/rendering/Geometry.hh Show resolved Hide resolved
adlarkin and others added 3 commits September 14, 2021 13:54
Signed-off-by: Ashton Larkin <ashton@openrobotics.org>
Signed-off-by: Ashton Larkin <ashton@openrobotics.org>
@codecov
Copy link

codecov bot commented Sep 14, 2021

Codecov Report

Merging #397 (117475f) into main (064bdf5) will increase coverage by 0.13%.
The diff coverage is 66.66%.

❗ Current head 117475f differs from pull request most recent head 7338105. Consider uploading reports for the commit 7338105 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #397      +/-   ##
==========================================
+ Coverage   55.05%   55.18%   +0.13%     
==========================================
  Files         191      191              
  Lines       19265    19348      +83     
==========================================
+ Hits        10607    10678      +71     
- Misses       8658     8670      +12     
Impacted Files Coverage Δ
include/ignition/rendering/Geometry.hh 100.00% <ø> (ø)
include/ignition/rendering/Mesh.hh 100.00% <ø> (ø)
include/ignition/rendering/Visual.hh 100.00% <ø> (ø)
include/ignition/rendering/base/BaseGeometry.hh 68.18% <0.00%> (-10.77%) ⬇️
ogre/src/OgreScene.cc 26.57% <0.00%> (-0.09%) ⬇️
include/ignition/rendering/base/BaseMesh.hh 65.57% <54.16%> (-1.78%) ⬇️
include/ignition/rendering/base/BaseCapsule.hh 89.28% <75.00%> (-10.72%) ⬇️
include/ignition/rendering/base/BaseVisual.hh 71.42% <76.74%> (+1.29%) ⬆️
ogre2/src/Ogre2Scene.cc 76.73% <100.00%> (+0.03%) ⬆️
include/ignition/rendering/base/BaseNode.hh 82.82% <0.00%> (+1.01%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 064bdf5...7338105. Read the comment docs.

Signed-off-by: Ashton Larkin <ashton@openrobotics.org>
Signed-off-by: Ashton Larkin <ashton@openrobotics.org>
adlarkin and others added 4 commits September 20, 2021 18:00
@iche033
Copy link
Contributor

iche033 commented Sep 21, 2021

I made some minor tweaks in #418. Can you take a look?

Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Copy link
Contributor

@iche033 iche033 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me.

will merge on green CI

Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@chapulina chapulina merged commit 5bf8dc6 into main Sep 22, 2021
@chapulina chapulina deleted the adlarkin/clone_visual branch September 22, 2021 04:47
Core development automation moved this from In review to Done Sep 22, 2021
@j-rivero j-rivero removed this from Done in Core development May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Targeting beta release of upcoming collection 🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants