-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ray query distance calculation #438
Conversation
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Codecov Report
@@ Coverage Diff @@
## ign-rendering4 #438 +/- ##
==================================================
+ Coverage 53.99% 55.83% +1.83%
==================================================
Files 147 147
Lines 14119 14120 +1
==================================================
+ Hits 7624 7884 +260
+ Misses 6495 6236 -259
Continue to review full report at Codecov.
|
* Fix ray query distance calculation (#438) * fix ray query dist calc Signed-off-by: Ian Chen <ichen@osrfoundation.org> * disable test Signed-off-by: Ian Chen <ichen@osrfoundation.org> * ogre: Add missing required Paging component (#452) Signed-off-by: Silvio <silvio@traversaro.it> * Fix selection buffer material script (#456) Signed-off-by: Ian Chen <ichen@osrfoundation.org> Co-authored-by: Ian Chen <ichen@osrfoundation.org> Co-authored-by: Silvio Traversaro <silvio@traversaro.it>
* fix ray query dist calc Signed-off-by: Ian Chen <ichen@osrfoundation.org> * disable test Signed-off-by: Ian Chen <ichen@osrfoundation.org>
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-01-10/1228/1 |
Signed-off-by: Ian Chen ichen@osrfoundation.org
馃 Bug fix
bug was introduced in #383 when the ray query code was converted to use selection buffer.
The distance result given was from the world origin to the intersection point. This PR fixes it so that it's from the camera to the intersection point.
The bug was not caught by the test as it was not testing ray queries using the selection buffer. This PR also turns it on in
UNIT_Utils_TEST
and fixes a few tol checks.UNIT_Utils_TEST
so disabled test in e13c1cdChecklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge