Avoid symbol redefition to fix armel builds #457
Conversation
Codecov Report
@@ Coverage Diff @@
## ign-rendering3 #457 +/- ##
===============================================
Coverage 53.35% 53.35%
===============================================
Files 131 131
Lines 12035 12035
===============================================
Hits 6421 6421
Misses 5614 5614
Continue to review full report at Codecov.
|
|
no related test failures but ABI checker is complaining though: |
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Signed-off-by: GitHub <noreply@github.com> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Co-authored-by: Jose Luis Rivero <jrivero@osrfoundation.org> Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
This reverts commit 6e25442. Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
j-rivero
force-pushed
the
redefition_patches_3
branch
from
1b2cfcc
to
8a0ea36
Compare
I just changed to only remove the symbols on armhf. The code was released without them, should be fine to remove them in that platform. |
|
one minor codecheck error, otherwise looks good: |
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
* ogre: Do not assume that ogre plugins have lib prefix on macOS (#454) Signed-off-by: Silvio <silvio@traversaro.it> * Fix compilation against Ogre 1.10.12 (#390) Signed-off-by: GitHub <noreply@github.com> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Co-authored-by: Jose Luis Rivero <jrivero@osrfoundation.org> * Avoid symbol redefition to fix armel builds (#457) * Avoid symbol redefiniition on armel builds Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org> * Fix logic on warning for ogre versions different than 1.9.x (#465) * Fix logic on warning for ogre versions different than 1.9.x Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org> * Fix context attributes of glXCreateContextAttribsARB. (#460) Signed-off-by: Hill Ma <hillma@google.com> Co-authored-by: Silvio Traversaro <silvio@traversaro.it> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Co-authored-by: Jose Luis Rivero <jrivero@osrfoundation.org> Co-authored-by: Hill Ma <mahiuchun@users.noreply.github.com>
* Avoid symbol redefiniition on armel builds Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
* Avoid symbol redefiniition on armel builds Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org> Signed-off-by: William Lew <WilliamMilesLew@gmail.com>
|
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-01-10/1228/1 |
🦟 Bug fix
Summary
armel builds (aka armhf) are particularly picky with the c++ standard due to the number of optimizations that they do. armhf build of ign-rendering6 failed with the following:
Looking at the code I found some template class declarations that somehow looked to me superflous. I tried removing them and the whole thing compiled in my local machine (amd64). When I ported the changes to debbuilder (via patch in debian) things seems to work.
armhf for Focal fixes with this patch here:
I did not look more for the original declaration/definitions of these symbols or if there were other reasons to make these declarations in these places. Let's see if the rest of the platforms are happy with the changes.
Checklist