Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use gz-utils test macros #624

Merged
merged 2 commits into from
May 12, 2022
Merged

Use gz-utils test macros #624

merged 2 commits into from
May 12, 2022

Conversation

chapulina
Copy link
Contributor

Summary

The utilities from gz-cmake are deprecated.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina requested a review from scpeters May 11, 2022 15:39
@chapulina chapulina requested a review from iche033 as a code owner May 11, 2022 15:39
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label May 11, 2022
@osrf-triage osrf-triage added this to Inbox in Core development May 11, 2022
@chapulina chapulina moved this from Inbox to In review in Core development May 11, 2022
@codecov
Copy link

codecov bot commented May 11, 2022

Codecov Report

Merging #624 (8188792) into ign-rendering6 (8afbc05) will not change coverage.
The diff coverage is n/a.

❗ Current head 8188792 differs from pull request most recent head 321cc5d. Consider uploading reports for the commit 321cc5d to get more accurate results

@@               Coverage Diff               @@
##           ign-rendering6     #624   +/-   ##
===============================================
  Coverage           80.00%   80.00%           
===============================================
  Files                   1        1           
  Lines                  15       15           
===============================================
  Hits                   12       12           
  Misses                  3        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8afbc05...321cc5d. Read the comment docs.

@iche033 iche033 merged commit 2163ff2 into ign-rendering6 May 12, 2022
Core development automation moved this from In review to Done May 12, 2022
@iche033 iche033 deleted the chapulina/6/test_utils branch May 12, 2022 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants