Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for GpuRays (lidar) visibility mask #625

Merged
merged 4 commits into from
May 12, 2022

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented May 11, 2022

Signed-off-by: Ian Chen ichen@osrfoundation.org

馃帀 New feature

Summary

Sets the visibility mask to GpuRays sensor. A visual will be visible to the sensor if (sensor's visibility mask & visual's visibility flags) evaluates to non-zeo. This is useful for omitting certain visuals from lidar returns, e.g. water plane.

Test it

Run the INTEGRATION_gpu_rays test.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@github-actions github-actions bot added the 馃彲 fortress Ignition Fortress label May 11, 2022
@osrf-triage osrf-triage added this to Inbox in Core development May 11, 2022
Copy link
Contributor

@mjcarroll mjcarroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

Core development automation moved this from Inbox to In review May 11, 2022
@codecov
Copy link

codecov bot commented May 11, 2022

Codecov Report

Merging #625 (d32ecb8) into ign-rendering6 (bb57d85) will not change coverage.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           ign-rendering6     #625   +/-   ##
===============================================
  Coverage           80.00%   80.00%           
===============================================
  Files                   1        1           
  Lines                  15       15           
===============================================
  Hits                   12       12           
  Misses                  3        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update bb57d85...d32ecb8. Read the comment docs.

Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor style comments, otherwise LGTM

test/integration/gpu_rays.cc Outdated Show resolved Hide resolved
test/integration/gpu_rays.cc Outdated Show resolved Hide resolved
test/integration/gpu_rays.cc Outdated Show resolved Hide resolved
test/integration/gpu_rays.cc Outdated Show resolved Hide resolved
test/integration/gpu_rays.cc Outdated Show resolved Hide resolved
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@iche033 iche033 merged commit 8afbc05 into ign-rendering6 May 12, 2022
Core development automation moved this from In review to Done May 12, 2022
@iche033 iche033 deleted the lidar_visibility_mask branch May 12, 2022 18:22
@chapulina chapulina added the mbzirc Sponsored by MBZIRC: https://github.com/osrf/mbzirc/ label May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
馃彲 fortress Ignition Fortress mbzirc Sponsored by MBZIRC: https://github.com/osrf/mbzirc/
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants