-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for GpuRays (lidar) visibility mask #625
Conversation
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with green CI
Codecov Report
@@ Coverage Diff @@
## ign-rendering6 #625 +/- ##
===============================================
Coverage 80.00% 80.00%
===============================================
Files 1 1
Lines 15 15
===============================================
Hits 12 12
Misses 3 3 Continue to review full report at Codecov.
|
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor style comments, otherwise LGTM
Signed-off-by: Ian Chen ichen@osrfoundation.org
馃帀 New feature
Summary
Sets the visibility mask to GpuRays sensor. A visual will be visible to the sensor if (sensor's visibility mask
&
visual's visibility flags) evaluates to non-zeo. This is useful for omitting certain visuals from lidar returns, e.g. water plane.Test it
Run the
INTEGRATION_gpu_rays
test.Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.