Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ogre2 AxisVisual and ArrowVisual #87

Merged
merged 3 commits into from
May 26, 2020
Merged

Add ogre2 AxisVisual and ArrowVisual #87

merged 3 commits into from
May 26, 2020

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented May 20, 2020

Implementation was already done in the base classes (BaseAxisVisual and BaseArrowVisual). This PR closes the loop by filling in the Create*Visual functions in Ogre2Scene class.

Added tests and updated simple_demo to include an axis visual

Signed-off-by: Ian Chen ichen@osrfoundation.org

@iche033
add ogre2 arrow and axis visual
bc80023 
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@iche033 iche033 requested a review from maryaB-osr as a code owner May 20, 2020 03:03
@osrf-triage osrf-triage added this to Inbox in Core development May 20, 2020
@github-actions github-actions bot added the 🔮 dome Ignition Dome label May 20, 2020
@iche033
changelog and remove unused code
2a7c554 
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@codecov
Copy link

codecov bot commented May 20, 2020 •
edited

Codecov Report

Merging #87 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #87   +/-   ##
======================================
  Coverage    7.56%   7.56%           
======================================
  Files          26      26           
  Lines        1744    1744           
======================================
  Hits          132     132           
  Misses       1612    1612

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7125d0...ff5d5dd. Read the comment docs.

@iche033 iche033 mentioned this pull request May 20, 2020
Closed
@iche033
changelog
ff5d5dd 
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@ahcorde ahcorde mentioned this pull request May 22, 2020
Closed
Core development automation moved this from Inbox to In review May 22, 2020
ahcorde
ahcorde approved these changes May 22, 2020
View reviewed changes
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this PR in here gazebosim/gz-sim#150

maryaB-osr
maryaB-osr approved these changes May 22, 2020
View reviewed changes
Copy link
Contributor

@maryaB-osr maryaB-osr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tutorial update is looks fine

@iche033 iche033 mentioned this pull request May 23, 2020
Closed
@ahcorde ahcorde mentioned this pull request May 25, 2020
Merged
@iche033 iche033 merged commit bcd9c49 into master May 26, 2020
Core development automation moved this from In review to Done May 26, 2020
@iche033 iche033 deleted the ogre2_arrow_axis branch May 26, 2020 18:03
@chapulina chapulina mentioned this pull request Nov 24, 2021
Open
@j-rivero j-rivero removed this from Done in Core development May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

@maryaB-osr maryaB-osr maryaB-osr approved these changes

Assignees
No one assigned
Labels
🔮 dome Ignition Dome
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@iche033 @ahcorde @maryaB-osr