Scale BaseAxis properly #88
Conversation
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #88 +/- ##
======================================
Coverage 7.56% 7.56%
======================================
Files 26 26
Lines 1744 1744
======================================
Hits 132 132
Misses 1612 1612 Continue to review full report at Codecov.
|
|
|
||
| public: virtual void SetLocalScale(double _scale) override; | ||
|
|
||
| public: virtual void SetLocalScale(const math::Vector3d &_scale) override; |
There was a problem hiding this comment.
I think you should be able to just override this version with math::Vector3d arg. The other two just calls this function so can be removed.
| template <class T> | ||
| void BaseAxisVisual<T>::SetLocalScale(const math::Vector3d &_scale) | ||
| { | ||
| xArrow->SetLocalScale(_scale.X(), _scale.Y(), _scale.Z()); |
There was a problem hiding this comment.
how about:
for (unsigned int i = 0; i < this->ChildCount(); ++i)
this->ChildByIndex(i)->SetLocalScale(_scale);
this way we don't need to declare the private xArrow, yArrow, zArrow variables
…ix/scale_baseaxis
…oved private declaration of arrows Signed-off-by: ahcorde <ahcorde@gmail.com>
|
This PR builds on top of this other PR #87 |
|
looks good, updated change log in 71f4e44 |
|
there is an issue in one of the test https://build.osrfoundation.org/job/ignition_rendering-ci-pr_any-ubuntu_auto-amd64/623/testReport/junit/(root)/AxisVisual_AxisVisualTest/AxisVisual_ogre/ |
…ionrobotics/ign-rendering into ahcorde/fix/scale_baseaxis
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
|
CI is green except on windows |
|
tests on windows are not fully working yet so the failures are expected |
Just an FYI that the buildfarmer's script indicates that these 2 failures are new on Windows: |
While I was adding the origin axes to ignition gazebo I checked that the scale for a BaseAxis is wrong. Current implementation:
Overriding the scale methods:
Signed-off-by: ahcorde ahcorde@gmail.com