Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Triggered cameras (take photos instead of videos) #185

Closed
chapulina opened this issue Jan 10, 2022 · 2 comments
Closed

Triggered cameras (take photos instead of videos) #185

chapulina opened this issue Jan 10, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@chapulina
Copy link
Contributor

chapulina commented Jan 10, 2022

Gazebo classic supports cameras that only capture images when triggered through ROS, see gazebo_ros_camera. When porting that to Ignition, we should make all cameras "triggerable" via an Ignition topic that can be bridged to a ROS topic with ros_ign.

Desired behavior

Cameras that have <triggered>true</triggered> will only capture an image when they receive a command on an Ignition topic (like taking a photo instead of recording a video).

Alternatives considered

Users may be able to achieve this with a custom plugin, but adding this functionality to all cameras by default should be easier to maintain and extend. We may also consider adding this functionality to all sensors? I can see this being useful for performance when using lidars, contact sensors, etc.

Implementation suggestion

  1. Add a <triggered> parameter to <sensor> on SDF. Or just to <camera>.
  2. Parse that tag in ign-sensors and provide the necessary topic and callbacks that enable triggering
@chapulina chapulina added the enhancement New feature or request label Jan 10, 2022
@osrf-triage osrf-triage added this to Inbox in Core development Jan 10, 2022
@mjcarroll
Copy link
Contributor

It would also be beneficial to support the PolledCamera interface from ROS: https://github.com/ros-perception/image_common/tree/noetic-devel/polled_camera

@chapulina chapulina moved this from Inbox to To do in Core development Jan 10, 2022
@chapulina
Copy link
Contributor Author

It would also be beneficial to support the PolledCamera interface from ROS

Nice! I think that could be added to ros_ign_image.

This was referenced Feb 8, 2022
@j-rivero j-rivero removed this from To do in Core development May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants