Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom rendering sensor example #1673

Open
adityapande-1995 opened this issue Aug 29, 2022 · 7 comments · May be fixed by #2406
Open

Custom rendering sensor example #1673

adityapande-1995 opened this issue Aug 29, 2022 · 7 comments · May be fixed by #2406
Assignees
@JEller98
Labels
documentation Improvements or additions to documentation enhancement New feature or request help wanted We accept pull requests! rendering Involves Ignition Rendering sensors Sensors and sensor data

Comments

@adityapande-1995
Copy link
Contributor

Desired behavior

We have a custom sensor example here : https://github.com/gazebosim/gz-sim/tree/ign-gazebo6/examples/plugin/custom_sensor_system , and it would be nice to have a custom rendering sensor example as well, that people could use as a template to write their own rendering sensors.

Implementation suggestion

We could leverage #1475, and use osrf/lrauv#213 and a guide. A start could be a camera sensor modified in a trivial way, like mirroring the image.
@adityapande-1995 adityapande-1995 added the enhancement New feature or request label Aug 29, 2022
@osrf-triage osrf-triage added this to Inbox in Core development Aug 29, 2022
@chapulina chapulina added rendering Involves Ignition Rendering sensors Sensors and sensor data labels Aug 29, 2022
@chapulina chapulina removed this from Inbox in Core development Aug 29, 2022
@chapulina chapulina added help wanted We accept pull requests! documentation Improvements or additions to documentation labels Aug 29, 2022
@Myzhar
Copy link

Myzhar commented Nov 15, 2022

A stereo camera example could be useful, it was available in Gazebo Classic, but there's nothing similar in the new Gazebo/Ignition.

@tejalbarnwal
Copy link

Hey, I would like to work on this issue.
I was considering building a mirror camera sensor first, with the doppler velocity log sensor and camera sensor serving as references. After that, I could create a stereo sensor as a conventional example.

@JEller98
Copy link

JEller98 commented Apr 7, 2024

Hello there, I'll get to work on implementing this. Will do some poking around to get a few ideas, and hopefully I and my team will be able to get something figured out!

@azeey
Copy link
Contributor

azeey commented Apr 8, 2024

Thanks @JEller98. I'll assign this to you. @tejalbarnwal Did you ever get a chance to work on this?

@tejalbarnwal
Copy link

Hi @azeey ,
I apologize for the inconvenience, but I haven't had the chance to work on it. I became busy with another matter, and regrettably, it slipped my mind.

@azeey
Copy link
Contributor

azeey commented Apr 8, 2024

@tejalbarnwal no worries. Just checking to make sure we are not duplicating our efforts. @JEller98 please go ahead!

@JEller98
Copy link

Hello there, my teammates had a few questions regarding this issue; we're fairly new to this, so apologies if any of these seem redundant:

What are the specifications of this request?
What is the expected functionality?
Is documentation available for the examples?
Should we follow the test cases created in TestSensorSystem.cc/TestSensorSystem.hh?
Where will this live in the codebase?
What are the expected inputs?
What are the expected outputs?
Who are the users?

Any information regarding these questions would be much appreciated.

JEller98 pushed a commit to JEller98/gz-sim that referenced this issue May 14, 2024
@jEllerGRC
Very, VERY rough attempt at creating a solution to Issue gazebosim#1673…
071271f 
…; code is completely untested and no tests have been written for it.
JEller98 pushed a commit to JEller98/gz-sim that referenced this issue May 14, 2024
@jEllerGRC
Very, VERY rough attempt at creating a solution to Issue gazebosim#1673…
81aa668 
…; code is completely untested and no tests have been written for it.
@JEller98 JEller98 linked a pull request May 14, 2024 that will close this issue
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JEller98 JEller98

Labels
documentation Improvements or additions to documentation enhancement New feature or request help wanted We accept pull requests! rendering Involves Ignition Rendering sensors Sensors and sensor data
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Attempted Custom Rendering Sensor Example JEller98/gz-sim
6 participants
@azeey @Myzhar @chapulina @adityapande-1995 @tejalbarnwal @JEller98