Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to set sensor depth topics independently ? #360

Open
doisyg opened this issue Sep 20, 2020 · 3 comments
Open

How to set sensor depth topics independently ? #360

doisyg opened this issue Sep 20, 2020 · 3 comments
Labels
enhancement New feature or request help wanted We accept pull requests!

Comments

@doisyg
Copy link
Contributor

doisyg commented Sep 20, 2020

No description provided.

@osrf-triage osrf-triage added this to Inbox in Core development Sep 20, 2020
@doisyg
Copy link
Contributor Author

doisyg commented Sep 20, 2020

Sensor depth outputs two topics: an depth image and a point cloud, however there is only one <topic> attribute under <sensor>.
Right now the depth image is outputted on /topic and the pointcloud on /topic/points
I looked quickly at the code, independently setting the 2 topics is not implemented. I could PR however, I am not sure what would be the best approach. Adding a <topic_points> attribute would imply modifying also the sdf format, right ? Or maybe implementing a remap feature ? But at which level ?

@doisyg
Copy link
Contributor Author

doisyg commented Sep 20, 2020

Ideally providing the equivalent of the gazebo libgazebo_ros_openni_kinect.so plugin attributes:

<depthImageTopicName>
<depthImageCameraInfoTopicName>
<pointCloudTopicName>

@chapulina
Copy link
Contributor

Adding a <topic_points> attribute would imply modifying also the sdf format, right ?

Correct

Or maybe implementing a remap feature ? But at which level ?

If you want it to be very generic, I think it would go at the ign-transport level.


I don't have a good idea of how to solve this without touching SDF. This feels a bit hacky, but we could support multiple topics within the <topic> tag and put a separator between them?

@chapulina chapulina removed this from Inbox in Core development Sep 21, 2020
@chapulina chapulina added enhancement New feature or request help wanted We accept pull requests! labels Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted We accept pull requests!
Projects
None yet
Development

No branches or pull requests

2 participants