Optimize rendering sensor pose updates

[iche033]

🦟 Bug fix

Related PR: gazebosim/gz-sensors#439

Summary

Currently we are updating the pose of all rendering sensors every iteration. This is not necessary as we currently do not expect sensor pose to change at runtime. This PR removes the pose updates every iteration and it now just sets the pose of these rendering sensors once they created. For camera based sensors, their pose transform is the combined result of //sensor/pose and //sensor/camera/pose (previously the //sensor/camera/pose sdf element was ignored and never used).

Here is an example world for test: camera_test.sdf. The world consists of 2 cameras sensors (rgb and depth) with pose offsets in //sensor/pose and //sensor/camera/pose. Together with gazebosim/gz-sensors#439, the camera sensor pose should be set correctly and you should see images like below:

Checklist

• Signed all commits for DCO
• Added tests
• Updated documentation (as needed)
• Updated migration guide (as needed)
• Consider updating Python bindings (if the library has them)
• codecheck passed (See contributing)
• All tests passed (See test coverage)
• While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

[azeey]

previously the //sensor/camera/pose sdf element was ignored and never used)

I imagine this would break some existing SDF files. I wonder if we should provide a flag to enable/disable this bugfix. We should add an entry in the migration guide regardless.

[iche033]

if we should provide a flag to enable/disable this bugfix

I am thinking that I can remove the camera pose change in this PR which is targeting a release branch so we don't break existing sdf files in Harmonic. I'll then create a separate PR targeting main with the camera pose change and a migration guide entry. How does that sound?

[azeey]

That sounds great!

[iche033]

removed camera pose changes in a129d93. I'll merge this forward to main first and then apply the camera pose changes in a separate PR.