Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix windows colcon build #65

Merged
merged 1 commit into from
Oct 16, 2021
Merged

Fix windows colcon build #65

merged 1 commit into from
Oct 16, 2021

Conversation

scpeters
Copy link
Member

馃 Bug fix

Fixes colcon builds on Windows

Summary

Some windows builds that use ign-tools have been failing since #63 was merged:

The solution is to generate to a unique folder based on $<CONFIG>

Testing with this branch:

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@scpeters
Fix windows colcon build
bae3ed2 
Generate to a unique folder based on $<CONFIG>

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@github-actions github-actions bot added 馃尡 garden Ignition Garden 馃彚 edifice Ignition Edifice 馃彲 fortress Ignition Fortress 馃彴 citadel Ignition Citadel 馃敭 dome Ignition Dome labels Oct 16, 2021
@osrf-triage osrf-triage added this to Inbox in Core development Oct 16, 2021
@scpeters scpeters mentioned this pull request Oct 16, 2021
Merged
7 tasks
Core development automation moved this from Inbox to In review Oct 16, 2021
@scpeters scpeters mentioned this pull request Oct 16, 2021
Merged
@scpeters scpeters merged commit 6cf3e35 into ign-tools1 Oct 16, 2021
Core development automation moved this from In review to Done Oct 16, 2021
@scpeters scpeters deleted the scpeters/fix_windows_colcon branch October 16, 2021 04:41
@scpeters scpeters mentioned this pull request Oct 29, 2021
Open
3 tasks
@j-rivero j-rivero removed this from Done in Core development May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

@azeey azeey Awaiting requested review from azeey

@caguero caguero Awaiting requested review from caguero caguero is a code owner

Assignees
No one assigned
Labels
馃彴 citadel Ignition Citadel 馃敭 dome Ignition Dome 馃彚 edifice Ignition Edifice 馃彲 fortress Ignition Fortress 馃尡 garden Ignition Garden
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@scpeters @chapulina