Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several ignition projects install the .yaml file even if the ruby script is not installed #71

Open
1 of 3 tasks
traversaro opened this issue Oct 29, 2021 · 5 comments
Open
1 of 3 tasks
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@traversaro
Copy link
Contributor

traversaro commented Oct 29, 2021

Desired behavior

While debugging a related problem, I noticed that on a Windows installation of a Ignition Fortress, ign --help was printing this message:

(igntools) C:\Users\STraversaro>ign --help
The 'ign' command provides a command line interface to the ignition tools.

  ign <command> [options]

List of available commands:

  help:          Print this help text.
  fuel:          Manage simulation resources.
  gui:           Launch graphical interfaces.
  msg:           Print information about messages.
  plugin:        Print information about plugins.
  sdf:           Utilities for SDF files.
  topic:         Print information about topics.
  service:       Print information about services.

Options:

  --force-version <VERSION>  Use a specific library version.
  --versions                 Show the available versions.
  --commands                 Show the available commands.
Use 'ign help <command>' to print help for a command.

But then for several of this commands, the execution failed with with error like:

(igntools) C:\Users\STraversaro>ign plugin
Traceback (most recent call last):
        2: from C:/Users/STraversaro/AppData/Local/mambaforge/envs/igntools/Library/bin//ign:274:in `<main>'
        1: from C:/Users/STraversaro/AppData/Local/mambaforge/envs/igntools/Library/lib/ruby/2.7.0/rubygems/core_ext/kernel_require.rb:92:in `require'
C:/Users/STraversaro/AppData/Local/mambaforge/envs/igntools/Library/lib/ruby/2.7.0/rubygems/core_ext/kernel_require.rb:92:in `require': cannot load such file -- C:/Users/STraversaro/AppData/Local/mambaforge/envs/igntools/Library/lib/ruby/ignition/cmdplugin1 (LoadError)

The problems seems that in many cases, even if the installation of the cmd<> ruby script is disable, the yaml file describing the ign-tool plugin is installed anyway.

This problem seems to affect the following repos:

Implementation suggestion

Probably for all this projects a single options should control the installation of both the yaml and rb ign-tools-related files.

Additional context

Even if strictly speaking this is not an ign-tools issue, I preferred to open an issue in ign-tools as the details of the issues affecting those repos are the same.

@traversaro traversaro added the enhancement New feature or request label Oct 29, 2021
@osrf-triage osrf-triage added this to Inbox in Core development Oct 29, 2021
@scpeters
Copy link
Member

I think both files should always be installed. For ign-plugin, there was a problem on windows, so the src/cmd folder was skipped in gazebosim/gz-plugin#38. We can fix the underlying issue using the change from #65

scpeters added a commit to scpeters/ign-plugin that referenced this issue Oct 30, 2021
This requires generating the .rb and .yaml files to folders
unique to $<CONFIG>.

Part of gazebosim/gz-tools#71.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters
Copy link
Member

fix for ign-plugin in gazebosim/gz-plugin#63

scpeters added a commit to gazebosim/gz-plugin that referenced this issue Nov 3, 2021
This requires generating the .rb and .yaml files to folders
unique to $<CONFIG>.

Part of gazebosim/gz-tools#71.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
ahcorde pushed a commit to gazebosim/gz-plugin that referenced this issue Nov 3, 2021
This requires generating the .rb and .yaml files to folders
unique to $<CONFIG>.

Part of gazebosim/gz-tools#71.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@chapulina chapulina removed this from Inbox in Core development Nov 12, 2021
@chapulina chapulina added the help wanted Extra attention is needed label Nov 12, 2021
@chapulina
Copy link
Contributor

As part of gazebo-tooling/release-tools#472 we've been updating all libraries to always install the files needed by gz-tools.

@traversaro
Copy link
Contributor Author

[ ] ign-msgs

This will be fixed by gazebosim/gz-msgs#402 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants