Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inline namespace issue with clang6 #39

Merged
merged 1 commit into from
Feb 24, 2022
Merged

Fix inline namespace issue with clang6 #39

merged 1 commit into from
Feb 24, 2022

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Feb 24, 2022

🦟 Bug fix

Fixes #36

Summary

For some reason clang6 doesn't pick up the inline namespace when defining functions with their fully qualified name (sans the inline namespace). This fixes the issue by defining the functions inside the inline namespace.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@mjcarroll
Copy link
Contributor

Verified that this works for me on Ubuntu 18.04

clang++-6.0 -v
clang version 6.0.1-14 (tags/RELEASE_601/final)
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/bin
Found candidate GCC installation: /usr/bin/../lib/gcc/x86_64-linux-gnu/8
Found candidate GCC installation: /usr/bin/../lib/gcc/x86_64-linux-gnu/9
Found candidate GCC installation: /usr/lib/gcc/x86_64-linux-gnu/8
Found candidate GCC installation: /usr/lib/gcc/x86_64-linux-gnu/9
Selected GCC installation: /usr/bin/../lib/gcc/x86_64-linux-gnu/9
Candidate multilib: .;@m64
Candidate multilib: 32;@m32
Candidate multilib: x32;@mx32
Selected multilib: .;@m64

@mjcarroll mjcarroll merged commit c5d1791 into ign-utils1 Feb 24, 2022
@mjcarroll mjcarroll deleted the fix_clang6 branch February 24, 2022 21:27
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-03-01-citadel-edifice-fortress/1313/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress 🌱 garden Ignition Garden
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ignition utils 1.2.0 doesn't build with ign-cmake 2.10.0 and with clang-6.0 compiler
3 participants