Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FindSQLite3: Add SQLite::SQLite3 ALIAS #313

Merged
merged 2 commits into from Oct 21, 2022

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Sep 29, 2022

🦟 Bug fix

Fixes (or provides a workaround) for #312 .

Summary

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@osrf-triage osrf-triage added this to Inbox in Core development Sep 29, 2022
@github-actions github-actions bot added 🏯 fortress Ignition Fortress 🏰 citadel Ignition Citadel labels Sep 29, 2022
… upstream FindSQLite3

Workaround for gazebosim#312 .

Signed-off-by: Silvio <silvio@traversaro.it>
@traversaro traversaro closed this Sep 29, 2022
Core development automation moved this from Inbox to Done Sep 29, 2022
@traversaro traversaro reopened this Sep 29, 2022
Core development automation moved this from Done to Inbox Sep 29, 2022
@azeey azeey moved this from Inbox to In review in Core development Oct 17, 2022
@scpeters scpeters changed the title FindSQLite3: Add SQLite::SQLite3 ALIAS for compatibility with CMake's upstream FindSQLite3 FindSQLite3: Add SQLite::SQLite3 ALIAS Oct 21, 2022
@scpeters scpeters merged commit f6d081a into gazebosim:ign-cmake2 Oct 21, 2022
Core development automation moved this from In review to Done Oct 21, 2022
@azeey
Copy link
Contributor

azeey commented Oct 26, 2022

This broke gz-transport11 for me on Ubuntu 20.04 with the error

-- Checking for module 'sqlite3 >= 3.7.13'
--   Found sqlite3 , version 3.31.1
CMake Error at /home/addisu/ws/fortress/install/share/cmake/ignition-cmake2/cmake2/FindSQLite3.cmake:62 (add_library):
  add_library cannot create ALIAS target "SQLite::SQLite3" because target
  "SQLite3::SQLite3" is imported but not globally visible.
Call Stack (most recent call first):
  /home/addisu/ws/fortress/install/share/cmake/ignition-cmake2/cmake2/IgnUtils.cmake:197 (find_package)
  CMakeLists.txt:107 (ign_find_package)


-- Looking for sqlite3 - found

@traversaro
Copy link
Contributor Author

Thanks for the report. Which CMake version are you using?

@traversaro
Copy link
Contributor Author

I think the error on my side is that I tested only on gz-cmake3 (where all the targets imported by g-cmake are GLOBAL due to #273) and I did not tested it on ign-cmake2 .

@traversaro
Copy link
Contributor Author

@azeey hopefully #317 should work fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel 🏯 fortress Ignition Fortress
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants