New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FindSQLite3: Add SQLite::SQLite3 ALIAS #313
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
traversaro
requested review from
mxgrey,
j-rivero and
scpeters
as code owners
September 29, 2022 14:56
github-actions
bot
added
🏯 fortress
Ignition Fortress
🏰 citadel
Ignition Citadel
labels
Sep 29, 2022
… upstream FindSQLite3 Workaround for gazebosim#312 . Signed-off-by: Silvio <silvio@traversaro.it>
scpeters
changed the title
FindSQLite3: Add SQLite::SQLite3 ALIAS for compatibility with CMake's upstream FindSQLite3
FindSQLite3: Add SQLite::SQLite3 ALIAS
Oct 21, 2022
scpeters
approved these changes
Oct 21, 2022
This broke gz-transport11 for me on Ubuntu 20.04 with the error
|
Thanks for the report. Which CMake version are you using? |
I think the error on my side is that I tested only on gz-cmake3 (where all the targets imported by g-cmake are |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes (or provides a workaround) for #312 .
Summary
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.