Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

FindSQLite3: Fix "cannot create ALIAS target" error #317

Merged
merged 3 commits into from
Oct 27, 2022

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Oct 26, 2022

馃 Bug fix

Summary

Fix the error reported by @azeey in #313 (comment) .

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@mjcarroll
Copy link
Contributor

Need a signoff on this one.

@traversaro
Copy link
Contributor Author

Need a signoff on this one.

Done! However, I did not test this extensively, so probably we can hear if this fix @azeey's problem.

@azeey
Copy link
Contributor

azeey commented Oct 27, 2022

I'm still getting an error:

-- Checking for module 'sqlite3 >= 3.7.13'
--   Found sqlite3 , version 3.31.1
CMake Error at /home/addisu/ws/fortress/install/share/cmake/ignition-cmake2/cmake2/FindSQLite3.cmake:62 (add_library):
  The target name "SQLite::SQLite3" is reserved or not valid for certain
  CMake features, such as generator expressions, and may result in undefined
  behavior.
Call Stack (most recent call first):
  /home/addisu/ws/fortress/install/share/cmake/ignition-cmake2/cmake2/IgnUtils.cmake:197 (find_package)
  CMakeLists.txt:107 (ign_find_package)


CMake Error at /home/addisu/ws/fortress/install/share/cmake/ignition-cmake2/cmake2/FindSQLite3.cmake:63 (target_link_libraries):
  Cannot specify link libraries for target "SQLite::SQLite3" which is not
  built by this project.
Call Stack (most recent call first):
  /home/addisu/ws/fortress/install/share/cmake/ignition-cmake2/cmake2/IgnUtils.cmake:197 (find_package)
  CMakeLists.txt:107 (ign_find_package)

@traversaro
Copy link
Contributor Author

Ack, let me try to setup a system where to test this.

cmake/FindSQLite3.cmake Outdated Show resolved Hide resolved
@traversaro
Copy link
Contributor Author

Thanks @azeey !

cmake/FindSQLite3.cmake Outdated Show resolved Hide resolved
traversaro and others added 3 commits October 27, 2022 19:23
Signed-off-by: Silvio <silvio@traversaro.it>
Co-authored-by: Addisu Z. Taddese <addisu@gmail.com>
Signed-off-by: Silvio <silvio@traversaro.it>
Signed-off-by: Silvio <silvio@traversaro.it>
Copy link
Contributor

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @traversaro for the quick iteration!

Core development automation moved this from Inbox to In review Oct 27, 2022
@j-rivero j-rivero merged commit 7eb7b79 into gazebosim:ign-cmake2 Oct 27, 2022
Core development automation moved this from In review to Done Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
馃彴 citadel Ignition Citadel 馃彲 fortress Ignition Fortress
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants