[ros2] Add JointTrajectory message conversion #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 3, 2020
chapulina
reviewed
Dec 4, 2020
There was a problem hiding this comment.
I haven't tried running it, but I took a high-level look and it looks good to me. I only noticed the small style issues pointed out below.
CI fails because it is not using fork of ign-msgs with ignition.msgs.JointTrajectory
The ros2 branch supports Citadel (ign-msgs5) and Dome (ign-msgs6). So before merging this PR, gazebosim/gz-msgs#106 needs to be:
- merged against
ign-msgs6 - backported to
ign-msgs5 - released into
ign-msgs 5.X - released into
ign-msgs 6.X
From your end, you just need to iterate on that PR until it gets merged, then the maintainers can take care of the rest.
Also, I am currently not using ROS 1 and therefore I unfortunately won't be looking into adding this conversion there.
No problem, we can ticket an issue to give it visibility in case someone else wants to pick it up.
chapulina
added
ROS 2
chapulina
reviewed
Dec 7, 2020
Conversion between - ignition::msgs::JointTrajectory - trajectory_msgs::msg::JointTrajectory Signed-off-by: Andrej Orsula <orsula.andrej@gmail.com>
Signed-off-by: Andrej Orsula <orsula.andrej@gmail.com>
Signed-off-by: Andrej Orsula <orsula.andrej@gmail.com>
Signed-off-by: Andrej Orsula <orsula.andrej@gmail.com>
Signed-off-by: Andrej Orsula <orsula.andrej@gmail.com>
- UPPER_CASE to lower_case Signed-off-by: Andrej Orsula <orsula.andrej@gmail.com>
AndrejOrsula
changed the title
This was referenced Dec 22, 2020
chapulina
removed
the
needs upstream release
chapulina
approved these changes
Jan 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds conversion between
trajectory_msgs/msg/JointTrajectoryandignition.msgs.JointTrajectory(PR - gazebosim/gz-msgs#106).Direction
ROS 2 -> Ignition Transportis tested withign_moveit2. However, I did NOT explicitly tryIgnition Transport -> ROS 2(besides running the automated tests).CI fails because it is not using fork of
ign-msgswithignition.msgs.JointTrajectory, hence it cannot be found. I am unsure about the best way to resolve this problem. Any help/suggestions are appreciated 馃檪.Also, I am currently not using ROS 1 and therefore I unfortunately won't be looking into adding this conversion there.