Add topic flag to create robot #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chapulina
reviewed
Dec 10, 2020
There was a problem hiding this comment.
Thanks for the PR, it works for me. I just have some minor comments below.
CC @clalancette in case you want to take a look too.
ros_ign_gazebo_demos/launch/robot_description_publisher.launch.py
Outdated
Show resolved
Hide resolved
ros_ign_gazebo_demos/launch/robot_description_publisher.launch.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Andrej Orsula <orsula.andrej@gmail.com> Signed-off-by: Valerio Magnago <valerio.magnago@hotmail.it>
Signed-off-by: Valerio Magnago <valerio.magnago@hotmail.it>
now the program should terminate with error when sending termination signal to the node while waiting ignition gazebo server to download the resource Signed-off-by: Valerio Magnago <valerio.magnago@hotmail.it>
Now it is possible to run ros_ign_gazebo create specifying a topic as source of the robot description Signed-off-by: Valerio Magnago <valerio.magnago@hotmail.it>
Add a launch file starting a ignition gazebo world and spawn a sphere in it. Additionally a rviz2 interface is loaded to show that also Rviz can load the robot description Signed-off-by: Valerio Magnago <valerio.magnago@hotmail.it>
Signed-off-by: Valerio Magnago <valerio.magnago@hotmail.it>
Signed-off-by: Valerio Magnago <valerio.magnago@hotmail.it>
The newly created demo introduce a dependency on the robot_state_publisher package Signed-off-by: Valerio Magnago <valerio.magnago@hotmail.it>
Now the loaded urdf is no more logged to the console Signed-off-by: Valerio Magnago <valerio.magnago@hotmail.it>
Add a base world with light and ground plane as base environment for the demo Co-authored-by: Louise Poubel <louise@openrobotics.org> Signed-off-by: Valerio Magnago <valerio.magnago@hotmail.it>
Co-authored-by: Louise Poubel <louise@openrobotics.org> Signed-off-by: Valerio Magnago <valerio.magnago@hotmail.it>
Add short docs of the demo on the README file and remove unuseful element from rviz configs. Signed-off-by: Valerio Magnago <valerio.magnago@hotmail.it>
|
@chapulina is there anything else that I can do here to help? |
chapulina
approved these changes
Dec 22, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #127
Proposed Changes
\robot_descriptiontopic by leveraging therobot_state_publisherand then use the newly defined flag to spawn the model in gazebo and additionally the launch starts rviz2 loading the robot descriptionrclcpp::ok()while server time to download resources. In case of failure the program will return -1