Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ros2] Minor updates for demos #144

Merged
merged 4 commits into from
Apr 5, 2021
Merged

[ros2] Minor updates for demos #144

merged 4 commits into from
Apr 5, 2021

Conversation

AndrejOrsula
Copy link
Contributor

馃 Bug fix

Summary

Few small changes, nothing significant

  • Re-enable air pressure demo
  • Add image_topic launch argument for image_bridge demo and use corresponding topics for depth and rgbd camera demos (instead of manually searching for the topic in drop-down menu)
  • Add RQt topic viewer to IMU demo, so that people have a way to see the output until RViz2 has IMU topic visualisation
  • Do not normalize depth image in RViz2 config and set its corresponding clip range. This allows it to be viewed (see comparison below - I am not sure about the glitch in the first few pixels though)

Before:
ros2_ign_rviz2_depth_image_viewer
After:
ros2_ign_rviz2_depth_image_viewer_fixed

Issues not resolved by this PR

The following issues still remain, but they all already have a TODO/FIXME note connected with them:

  • All demos blocked by "Blocked by ros_ign_point_cloud issue"
    • Depth camera, RGBD camera, GPU lidar (they all have a TODO note connected with them)
  • Battery
    • RQt is not plotting the data properly
    • There is a FIXME for this inside battery.launch.py script
  • IMU
    • RViz2 still does not seem to have IMU topic visualisation

Checklist

  • Signed all commits for DCO
  • Updated documentation (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)

Note to maintainers: Remember to use Squash-Merge

- Resolves #78

Signed-off-by: Andrej Orsula <orsula.andrej@gmail.com>
Signed-off-by: Andrej Orsula <orsula.andrej@gmail.com>
Signed-off-by: Andrej Orsula <orsula.andrej@gmail.com>
Signed-off-by: Andrej Orsula <orsula.andrej@gmail.com>
@chapulina chapulina added this to Inbox in Core development via automation Mar 26, 2021
@chapulina chapulina added documentation Improvements or additions to documentation ROS 2 ROS 2 labels Mar 26, 2021
@chapulina chapulina moved this from Inbox to In review in Core development Mar 26, 2021
@chapulina
Copy link
Contributor

I'll close and open to nudge Travis

@chapulina chapulina closed this Mar 29, 2021
Core development automation moved this from In review to Done Mar 29, 2021
@chapulina chapulina reopened this Mar 29, 2021
Core development automation moved this from Done to Inbox Mar 29, 2021
@chapulina chapulina moved this from Inbox to In review in Core development Mar 29, 2021
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃帀

@chapulina chapulina merged commit dfa5ad0 into gazebosim:ros2 Apr 5, 2021
Core development automation moved this from In review to Done Apr 5, 2021
@j-rivero j-rivero removed this from Done in Core development May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation ROS 2 ROS 2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants