Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bridge FluidPressure for ROS 2 #78

Closed
1 of 3 tasks
chapulina opened this issue Jun 7, 2020 · 1 comment
Closed
1 of 3 tasks

Bridge FluidPressure for ROS 2 #78

chapulina opened this issue Jun 7, 2020 · 1 comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers ROS 2 ROS 2

Comments

@chapulina
Copy link
Contributor

chapulina commented Jun 7, 2020 •
edited
Loading

I don't remember why that message was not ported to ROS 2. The message is on common_interfaces.

We should remember to do all these:
@chapulina chapulina added enhancement New feature or request good first issue Good for newcomers ROS 2 ROS 2 labels Jun 7, 2020
@chapulina chapulina mentioned this issue Jun 12, 2020
Merged
@chapulina chapulina mentioned this issue Jul 23, 2020
Merged
@chapulina
Copy link
Contributor Author

Humm now I don't remember why I was under the impression that FluidPressure hadn't been ported. It was ported together with the rest of messages on #45.

I guess the only thing missing is re-enabling the launch file and removing the TODOs 🤷‍♀️

@chapulina chapulina added the documentation Improvements or additions to documentation label Oct 17, 2020
@AndrejOrsula AndrejOrsula mentioned this issue Mar 26, 2021
Merged
4 tasks
chapulina pushed a commit that referenced this issue Apr 5, 2021
@AndrejOrsula
[ros2] Minor updates for demos (#144)
dfa5ad0 
* Re-enable air pressure demo
- Resolves #78

* Add RQt topic viewer to IMU demo
* Add image_topic argument for image_bridge demo
* Do not normalize depth image in RViz2

Signed-off-by: Andrej Orsula <orsula.andrej@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers ROS 2 ROS 2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chapulina