Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to Edifice for Rolling #150

Merged
merged 1 commit into from
Apr 16, 2021
Merged

Conversation

chapulina
Copy link
Contributor

馃 Bug fix

Summary

While releasing ros_ign for Rolling, I noticed pretty late during the release process that bloom doesn't respect local conditionals, see ros-infrastructure/bloom#517.

I was using the ros2 branch to release. That branch supported both Foxy and Rolling. Foxy is supposed to be released with Citadel, and Rolling (future Galactic) with Edifice. For that reason, the branch would default to Citadel if IGNITION_VERSION was not set. The problem is that there was no way to pass the env var to bloom to tell it to release with Edifice for Rolling.

The quickest solution right now is branching off for Rolling. I created a new foxy branch off the last commit before I created the changelog for the rolling release.

This PR flips the default on the ros2 branch from Citadel to Edifice. Once this is merged, I'll rerun bloom-release.

CC @nuclearsandwich

Note to maintainers: Remember to use Squash-Merge

馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻

Signed-off-by: Louise Poubel <louise@openrobotics.org>
Copy link
Contributor

@j-rivero j-rivero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can not detect any error. We have that death code of pointcloud still floating around but I assume we don't want to update it without a good reason.

@chapulina chapulina merged commit 14d1710 into ros2 Apr 16, 2021
@chapulina chapulina deleted the chapulina/rolling/default_to_edifice branch April 16, 2021 21:21
Core development automation moved this from In review to Done Apr 16, 2021
@chapulina chapulina mentioned this pull request Jun 14, 2021
@chapulina chapulina mentioned this pull request Dec 29, 2021
11 tasks
@j-rivero j-rivero removed this from Done in Core development May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ROS 2 ROS 2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants