Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch off for Galactic #200

Closed
9 of 11 tasks
chapulina opened this issue Dec 29, 2021 · 0 comments
Closed
9 of 11 tasks

Branch off for Galactic #200

chapulina opened this issue Dec 29, 2021 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@chapulina
Copy link
Contributor

chapulina commented Dec 29, 2021

We're ready to default to Fortress for Rolling. Since bloom doesn't allow the injection of custom environment variables (see ros-infrastructure/bloom#517), the release will always take the default conditionals on package.xml and CMakeLists.txt. This means we need to branch off just so each branch defaults to a different version:

  • galactic defaults to Edifice
  • ros2 (rolling, future humble) defaults to Fortress

Desired behavior

The galactic branch can be released using Edifice and the ros2 branch can be released using Fortress.

Alternatives considered

I can't think of anything besides bloom allowing the injection of environment variables, or another way of passing parameters.

Implementation suggestion

Additional context

Previous tickets which provide more context:

@chapulina chapulina added the enhancement New feature or request label Dec 29, 2021
@chapulina chapulina self-assigned this Dec 29, 2021
@osrf-triage osrf-triage added this to Inbox in Core development Dec 29, 2021
@chapulina chapulina moved this from Inbox to In progress in Core development Dec 29, 2021
Core development automation moved this from In progress to Done Mar 3, 2022
@j-rivero j-rivero removed this from Done in Core development May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant