Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose ignition::msgs::Contact through ROS 2 msgs #174

Closed
vatanaksoytezer opened this issue Aug 13, 2021 · 2 comments
Closed

Expose ignition::msgs::Contact through ROS 2 msgs #174

vatanaksoytezer opened this issue Aug 13, 2021 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@vatanaksoytezer
Copy link
Contributor

Contact sensors are working nicely in Ignition through ignition::msgs::Contact. But they are not exposed through ros_ign.

I don't mind adding another conversion to the ros_ign_bridge, but I am not %100 sure what ROS message type I should use. I couldn't fit this to any existing ROS2 message. I can of course define a custom message type or create a new message package (ala gazebo_msgs), but I just want this to be mergeable contribution, so this issue is to discuss what you would be happy to do. Let me know which option would be better to expose this and I will be happy to implement it @chapulina.

For reference ignition::msgs::Contact has type:

header {
  stamp {
    sec: 6
    nsec: 884000000
  }
}
contact {
  header {
    stamp {
      sec: 6
      nsec: 884000000
    }
  }
  collision1 {
    id: 96
  }
  collision2 {
    id: 7
  }
  position {
    x: -0.38790994410051866
    y: -0.21047000000004118
    z: -3.3862761483760551e-09
  }
  position {
    x: -0.38790994409679119
    y: -0.15047000000004118
    z: -3.4019649319816381e-09
  }
}

@vatanaksoytezer vatanaksoytezer added the enhancement New feature or request label Aug 13, 2021
@osrf-triage osrf-triage added this to Inbox in Core development Aug 13, 2021
@chapulina
Copy link
Contributor

define a custom message type or create a new message package (ala gazebo_msgs),

Ohh have you seen the ones recently added in #152?

@vatanaksoytezer
Copy link
Contributor Author

vatanaksoytezer commented Aug 13, 2021

Ohh have you seen the ones recently added in #152?

Oh, those look neat! Will send a PR soon for bridge and hopefully close this after it gets merged! Thanks!

@chapulina chapulina moved this from Inbox to In progress in Core development Aug 13, 2021
Core development automation moved this from In progress to Done Aug 18, 2021
@j-rivero j-rivero removed this from Done in Core development May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants