Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create.cpp usage message fixed for ros2 branch #207

Merged
merged 2 commits into from
Jan 13, 2022
Merged

create.cpp usage message fixed for ros2 branch #207

merged 2 commits into from
Jan 13, 2022

Conversation

Aryaman22102002
Copy link
Contributor

Signed-off-by: Aryaman aryashardul2002@gmail.com

This fixes ros_ign_gazebo create.cpp usage message incorrect #190 .

@Aryaman22102002
create.cpp usage message fixed for ros2 branch
a899d4d 
Signed-off-by: Aryaman <aryashardul2002@gmail.com>
chapulina
chapulina reviewed Jan 12, 2022
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! I just noticed that allow_renaming is also missing, mind adding it too?

@Aryaman22102002
allow_renaming added in usage message
9c1c863 
Signed-off-by: Aryaman <aryashardul2002@gmail.com>
Aryaman22102002
Aryaman22102002 commented Jan 13, 2022
View reviewed changes
Copy link
Contributor Author

@Aryaman22102002 Aryaman22102002 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

allow_renaming has now been added in usage message.

chapulina
chapulina approved these changes Jan 13, 2022
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@chapulina chapulina merged commit 0b5263c into gazebosim:ros2 Jan 13, 2022
@chapulina chapulina added the ROS 2 ROS 2 label Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

Assignees
No one assigned
Labels
ROS 2 ROS 2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Aryaman22102002 @chapulina