Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring ros2 branch up-to-date with Rolling #213

Merged
merged 3 commits into from
Jan 28, 2022
Merged

Bring ros2 branch up-to-date with Rolling #213

merged 3 commits into from
Jan 28, 2022

Conversation

mjcarroll
Copy link
Collaborator

@mjcarroll mjcarroll commented Jan 28, 2022 •
edited
Loading

In order to build clean on rolling:

  • change the deprecated use of declare_parameters
  • Add a pure virtual destructor to FactoryInterface (at least for clang/llvm)
  • Make linters pass

Broke this off of #212 for easier review

@osrf-triage osrf-triage added this to Inbox in Core development Jan 28, 2022
@mjcarroll mjcarroll force-pushed the rolling_updates branch 2 times, most recently from fab8219 to 883340a Compare January 28, 2022 17:29
@mjcarroll
Change use of deprecated declare_parameter
432d29f 
Signed-off-by: Michael Carroll <michael@openrobotics.org>
@mjcarroll
Add pure virtual destructor for FactoryInterface
d685d52 
Signed-off-by: Michael Carroll <michael@openrobotics.org>
@mjcarroll
Make linters pass for Rolling
761fe91 
Signed-off-by: Michael Carroll <michael@openrobotics.org>
@chapulina chapulina mentioned this pull request Jan 28, 2022
Merged
8 tasks
chapulina
chapulina approved these changes Jan 28, 2022
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I just have a question about the pure-virtual destructor

ros_ign_bridge/src/factory_interface.hpp Show resolved Hide resolved
Core development automation moved this from Inbox to In review Jan 28, 2022
@chapulina chapulina merged commit 05da9b7 into ros2 Jan 28, 2022
Core development automation moved this from In review to Done Jan 28, 2022
@chapulina chapulina deleted the rolling_updates branch January 28, 2022 18:56
@j-rivero j-rivero removed this from Done in Core development May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mjcarroll @chapulina