Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ros_ign_interfaces] Add GuiCamera, StringVec, TrackVisual, VideoRecord #214

Merged
merged 6 commits into from
Feb 7, 2022

Conversation

ivanpauno
Copy link
Contributor

🎉 New feature

Split from #211.

Summary

Add ROS 2 interfaces for four ignition specific messages and their conversion functions.
They could be useful to bridge some of the common ignition services.

Test it

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

* GuiCamera
* StringVec
* TrackVisual
* VideoRecord

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno ivanpauno force-pushed the ivanpauno/add-msgs-ros-ign-interfaces branch from 5e13136 to c2e7f57 Compare February 1, 2022 14:18
@ivanpauno ivanpauno added the enhancement New feature or request label Feb 1, 2022
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@mjcarroll mjcarroll merged commit 6334294 into ros2 Feb 7, 2022
@mjcarroll mjcarroll deleted the ivanpauno/add-msgs-ros-ign-interfaces branch February 7, 2022 19:03
@ivanpauno ivanpauno mentioned this pull request Feb 7, 2022
8 tasks
mjcarroll pushed a commit that referenced this pull request Apr 12, 2022
…rd (#214)

* [ros_ign_interfaces] Add more interface definitions.
* Add converion functions for the added messages
* Update the factory factory function with the new messages
* Add new messages to docs
* Add test cases for the new messages conversions

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants