Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add conversions for ros_ign_interfaces/WorldControl and builtin_interfaces/Time #216

Merged
merged 9 commits into from
Feb 10, 2022
Merged

Add conversions for ros_ign_interfaces/WorldControl and builtin_interfaces/Time #216

merged 9 commits into from
Feb 10, 2022

Conversation

ivanpauno
Copy link
Contributor

@ivanpauno ivanpauno commented Feb 8, 2022 •
edited
Loading

馃帀 New feature

Split from #211.

Summary

Add the following conversions:

  • ros_ign_interfaces/WorldControl <-> ignition.msgs.WorldControl
  • builtin_interfaces/Time <-> ignition.msgs.Time

Test it

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@ivanpauno
Add conversion methods for WorldControl msg and Time
28d4978 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno
Add WorldControl to factory
04a78de 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno
Reuse Time coversion functions for Header
25531c8 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno
Add builtin_interfaces to factories.cpp
72ac90f 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno ivanpauno added the enhancement New feature or request label Feb 8, 2022
@ivanpauno ivanpauno self-assigned this Feb 8, 2022
@osrf-triage osrf-triage added this to Inbox in Core development Feb 8, 2022
@ivanpauno
Please cpplint
3d5c8ca 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno
Document the new conversions
dabe135 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno
Add test cases for the new conversions
6a4b840 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@mjcarroll mjcarroll self-requested a review February 9, 2022 15:27
@mjcarroll mjcarroll moved this from Inbox to In review in Core development Feb 9, 2022
mjcarroll
mjcarroll reviewed Feb 9, 2022
View reviewed changes
ros_ign_bridge/README.md Outdated Show resolved Hide resolved
ros_ign_bridge/CMakeLists.txt Outdated Show resolved Hide resolved
ivanpauno and others added 2 commits February 9, 2022 13:24
@ivanpauno @mjcarroll
WorldContro -> WorldControl
b7756ad 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>

Co-authored-by: Michael Carroll <michael@openrobotics.org>
@ivanpauno
Delete unneeded lines
d0b6d99 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@mjcarroll mjcarroll merged commit 928cae7 into ros2 Feb 10, 2022
@mjcarroll mjcarroll deleted the ivanpauno/add-conversions-for-worldcontrol-and-time branch February 10, 2022 15:14
Core development automation moved this from In review to Done Feb 10, 2022
@ivanpauno ivanpauno mentioned this pull request Mar 3, 2022
Merged
8 tasks
@j-rivero j-rivero removed this from Done in Core development May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjcarroll mjcarroll mjcarroll approved these changes

@chapulina chapulina Awaiting requested review from chapulina

Assignees

@ivanpauno ivanpauno

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ivanpauno @mjcarroll