Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed ros_ign_gazebo launch file install directory #229

Merged
merged 1 commit into from
Apr 1, 2022
Merged

Fixed ros_ign_gazebo launch file install directory #229

merged 1 commit into from
Apr 1, 2022

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented Mar 31, 2022

馃 Bug fix

Related with this comment #226 (comment)

FYI @doisyg

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@ahcorde
Fixed ros_ign_gazebo launch file install directory
6471b04 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde requested a review from chapulina as a code owner March 31, 2022 16:25
@ahcorde ahcorde self-assigned this Mar 31, 2022
@osrf-triage osrf-triage added this to Inbox in Core development Mar 31, 2022
@doisyg
Copy link
Contributor

doisyg commented Mar 31, 2022

Great!

@ahcorde ahcorde requested a review from mjcarroll April 1, 2022 08:01
Core development automation moved this from Inbox to In review Apr 1, 2022
@ahcorde ahcorde merged commit cdc04da into foxy Apr 1, 2022
Core development automation moved this from In review to Done Apr 1, 2022
@ahcorde ahcorde deleted the ahcorde/fix/launch_file_install_dir branch April 1, 2022 16:36
ahcorde added a commit that referenced this pull request Apr 1, 2022
@ahcorde
Fixed ros_ign_gazebo launch file install directory (#229) (#230)
2e31fee 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@j-rivero j-rivero removed this from Done in Core development May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjcarroll mjcarroll mjcarroll approved these changes

@chapulina chapulina Awaiting requested review from chapulina

Assignees

@ahcorde ahcorde

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ahcorde @doisyg @mjcarroll