Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

add std_msgs as dependency #242

Merged
merged 1 commit into from
Apr 22, 2022
Merged

add std_msgs as dependency #242

merged 1 commit into from
Apr 22, 2022

Conversation

ijnek
Copy link
Contributor

@ijnek ijnek commented Apr 16, 2022

Signed-off-by: Kenji Brameld kenjibrameld@gmail.com

馃 Bug fix

Bug

ROS2 Rolling on Ubuntu Jammy fails to build due to missing dependency on std_msgs.

ros_ign_ws $colcon build --packages-select ros_ign_gazebo
Starting >>> ros_ign_gazebo
--- stderr: ros_ign_gazebo                             
/home/ijnek/workspaces_ros2/ros_ign_ws/src/ros_ign/ros_ign_gazebo/src/create.cpp:25:10: fatal error: std_msgs/msg/string.hpp: No such file or directory
   25 | #include <std_msgs/msg/string.hpp>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
gmake[2]: *** [CMakeFiles/create.dir/build.make:76: CMakeFiles/create.dir/src/create.cpp.o] Error 1
gmake[1]: *** [CMakeFiles/Makefile2:137: CMakeFiles/create.dir/all] Error 2
gmake: *** [Makefile:146: all] Error 2
---
Failed   <<< ros_ign_gazebo [2.55s, exited with code 2]

Summary: 0 packages finished [2.75s]
  1 package failed: ros_ign_gazebo
  1 package had stderr output: ros_ign_gazebo

Summary

Adds dependency to package.xml and CMakeLists.txt.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com>
@ijnek ijnek requested a review from chapulina as a code owner April 16, 2022 09:55
@ahcorde ahcorde mentioned this pull request Apr 21, 2022
7 tasks
Copy link
Contributor

@adityapande-1995 adityapande-1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahcorde should we also declare ignition-transport and ignition-msgs as explicit dependencies ? Used here : https://github.com/ignitionrobotics/ros_ign/blob/c7f74b75ed37cdb90b76df5821b575f2b9a225ad/ros_ign_gazebo/src/create.cpp#L17-L19

@ahcorde
Copy link
Collaborator

ahcorde commented Apr 21, 2022

@ahcorde should we also declare ignition-transport and ignition-msgs as explicit dependencies ? Used here :

https://github.com/ignitionrobotics/ros_ign/blob/c7f74b75ed37cdb90b76df5821b575f2b9a225ad/ros_ign_gazebo/src/create.cpp#L17-L19

If this is used of course we have to.

@ijnek do you mind to add then ?

Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I believe this closes #220. We may need to backport it to foxy and galactic

@ahcorde
Copy link
Collaborator

ahcorde commented Apr 21, 2022

@chapulina CI is still red because of the Jammy packages, should we wait to get a green CI ?

@ahcorde
Copy link
Collaborator

ahcorde commented Apr 22, 2022

@ros-pull-request-builder retest this please

@chapulina
Copy link
Contributor

ros_ign_gazebo built fine on the ROS farm, which is all we need to verify that this PR works. Merging to unblock follow up PRs.

@chapulina chapulina merged commit e1ec514 into gazebosim:ros2 Apr 22, 2022
@ijnek ijnek deleted the std-msgs-dependency branch April 22, 2022 21:45
mjcarroll pushed a commit that referenced this pull request Jun 23, 2022
Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants