-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
add std_msgs as dependency #242
Conversation
Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ahcorde should we also declare ignition-transport
and ignition-msgs
as explicit dependencies ? Used here : https://github.com/ignitionrobotics/ros_ign/blob/c7f74b75ed37cdb90b76df5821b575f2b9a225ad/ros_ign_gazebo/src/create.cpp#L17-L19
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I believe this closes #220. We may need to backport it to foxy
and galactic
@chapulina CI is still red because of the Jammy packages, should we wait to get a green CI ? |
@ros-pull-request-builder retest this please |
|
Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com>
Signed-off-by: Kenji Brameld kenjibrameld@gmail.com
馃 Bug fix
Bug
ROS2 Rolling on Ubuntu Jammy fails to build due to missing dependency on
std_msgs
.Summary
Adds dependency to
package.xml
andCMakeLists.txt
.Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.