Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace ign with gz in ros_gz_bridge README #303

Merged
merged 1 commit into from
Sep 28, 2022
Merged

replace ign with gz in ros_gz_bridge README #303

merged 1 commit into from
Sep 28, 2022

Conversation

oKermorgant
Copy link
Contributor

ros_gz_bridge documentation in ros2 and humble branches still use the IGN prefix for the config_file that may be passed to parameter_bridge.

@osrf-triage osrf-triage added this to Inbox in Core development Sep 27, 2022
@oKermorgant
replace ign with gz in ros_gz_bridge README
3fba5bf 
Signed-off-by: Olivier Kermorgant <olivier_kermorgant@yahoo.fr>
mjcarroll
mjcarroll approved these changes Sep 27, 2022
View reviewed changes
Copy link
Collaborator

@mjcarroll mjcarroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

Core development automation moved this from Inbox to In review Sep 27, 2022
@mjcarroll mjcarroll merged commit 84835ad into gazebosim:humble Sep 28, 2022
Core development automation moved this from In review to Done Sep 28, 2022
@oKermorgant oKermorgant mentioned this pull request Oct 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjcarroll mjcarroll mjcarroll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Core development
Archived in project
Core development
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@oKermorgant @mjcarroll