Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conversion for geometry_msgs/msg/TwistStamped <-> gz.msgs.Twist #468

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Dec 6, 2023

🎉 New feature

Summary

There's an effort to migrate to using TwistStamped for cmd_vel messages (see ros-navigation/navigation2#1594). This PR adds a converter for gz.msgs.Twist since it already has the header information (see twist.proto).

I've also done some cleanup and regenerated the conversion table.

Test it

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

cc @SteveMacenski

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey azeey requested a review from ahcorde as a code owner December 6, 2023 01:20
@SteveMacenski
Copy link

Can't comment on the technical completeness, but great to see! Is the plan to backport this to whatever is running on Humble / Iron today?

@ahcorde ahcorde merged commit a982161 into gazebosim:ros2 Dec 7, 2023
5 checks passed
@azeey azeey deleted the twist_stamped branch December 7, 2023 21:58
@azeey
Copy link
Contributor Author

azeey commented Dec 7, 2023

Can't comment on the technical completeness, but great to see! Is the plan to backport this to whatever is running on Humble / Iron today?

Yes, I'll go ahead and backport it to the humble and iron branches.

@SteveMacenski
Copy link

OK. Can you email me once this is in binaries for Rolling at the very least?

@Ryanf55
Copy link

Ryanf55 commented Dec 8, 2023

This is excellent to see. This was one of the biggest risks to my choice to use TwistStamped in ArduPilot and NAV2 for our GSoC project. Thank you to everyone involved here in making this happen in ros_gz before the API freeze in J-Turtle.
@srmainwaring FYI let's keep tabs on the backport and next humble sync.

azeey added a commit to azeey/ros_gz that referenced this pull request Dec 12, 2023
…gs.Twist (gazebosim#468)

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
azeey added a commit to azeey/ros_gz that referenced this pull request Dec 12, 2023
…gs.Twist (gazebosim#468)

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
ahcorde pushed a commit that referenced this pull request Dec 12, 2023
…gs.Twist (#468) (#470)

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
azeey added a commit to azeey/ros_gz that referenced this pull request Dec 13, 2023
…gs.Twist (gazebosim#468)

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
ahcorde pushed a commit that referenced this pull request Dec 13, 2023
…gs.Twist (#468) (#471)

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@AltinayGrass
Copy link

Is there any plan for "gazebo_ros_pkgs/gazebo_plugins/src/gazebo_ros_planar_move.cpp" ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

6 participants