Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated launch file to use ros_ign_gazebo #82

Merged
merged 23 commits into from
Jul 2, 2020
Merged

Updated launch file to use ros_ign_gazebo #82

merged 23 commits into from
Jul 2, 2020

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented Jun 9, 2020

This PR builds on top of this other PR #80

This PR update the lanch file to use the launch file inside ros_ign_gazebo

Signed-off-by: ahcorde ahcorde@gmail.com

@ahcorde
Added ros_ign_gazebo for ros2
b64a742 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde
Execute permission to ign_gazebo script
55961cf 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde
Added arguments for the gui too
09a280c 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde added the enhancement New feature or request label Jun 9, 2020
@ahcorde ahcorde requested a review from chapulina June 9, 2020 13:53
@ahcorde ahcorde self-assigned this Jun 9, 2020
@osrf-triage osrf-triage added this to Inbox in Core development Jun 9, 2020
@ahcorde
Added missing imports in ign_gazebo_ros gui launch
d18b4ea 
Signed-off-by: ahcorde <ahcorde@gmail.com>
chapulina
chapulina reviewed Jun 12, 2020
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we rebase this on top of #80 ? Otherwise it's hard to test if things are working.

Also note that ros_ign_gazebo_demos/README.md will need updates too.

ros_ign_gazebo_demos/launch/air_pressure.launch.py Outdated
package='ros_ign_bridge',
node_executable='parameter_bridge',
arguments=['/air_pressure@sensor_msgs/msg/FluidPressure@ignition.msgs.FluidPressure'],
output='screen'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't work yet, right? See #78

ros_ign_gazebo_demos/launch/battery.launch.py Show resolved Hide resolved
chapulina and others added 6 commits June 12, 2020 18:55
@chapulina
single entrypoint, let ign-gazebo manage processes
ca68f0c 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina
fallback to getting world name from service
7b343f0 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina
gflags
91faacf 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina
correct rosdep keys
b0527a1 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@ahcorde
removed ign_gazebo script
e02839d 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde
Update package.xml
8effbf4 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde force-pushed the ahcorde/ros_ign_gazebo_demos branch from 919cb0e to aae9586 Compare June 15, 2020 14:49
@ahcorde ahcorde changed the base branch from dashing to ahcorde/add/ros_ign_gazebo June 15, 2020 14:51
@ahcorde
Avoid the use of --ros-args arguments outside ros
09d494e 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde
Merge remote-tracking branch 'origin/chapulina/add/ros_ign_gazebo' in…
7d3623d 
…to ahcorde/add/ros_ign_gazebo
@ahcorde
Updated launch file to use ros_ign_gazebo
918e09c 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde
updated launch files
c6ffeac 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde
Used ign_args
eee5f60 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde force-pushed the ahcorde/ros_ign_gazebo_demos branch from aae9586 to eee5f60 Compare June 15, 2020 15:13
@chapulina chapulina moved this from Inbox to In review in Core development Jun 15, 2020
Base automatically changed from ahcorde/add/ros_ign_gazebo to dashing June 15, 2020 21:53
@chapulina
Copy link
Contributor

#80 and #81 have been merged. I think this needs to be rebased and maybe needs a couple of tweaks.

@ahcorde ahcorde mentioned this pull request Jun 16, 2020
Open
chapulina
chapulina suggested changes Jun 24, 2020
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before merging, we should make sure that all ros_ign_gazebo_demos work with dashing on this branch.

ros_ign_gazebo_demos/launch/image_bridge.launch.py Show resolved Hide resolved
@chapulina chapulina mentioned this pull request Jun 24, 2020
Merged
@chapulina
Copy link
Contributor

See #85 for a Dashing-compatible version.

@ahcorde ahcorde changed the base branch from dashing to ros2 June 26, 2020 09:44
@ahcorde
Merge remote-tracking branch 'origin/ros2' into ahcorde/ros_ign_gazeb…
19770cf 
…o_demos
@ahcorde
Fixed merge
6811479 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde
Fixed merge
9d86c93 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde
Fixed travis
9e6c54d 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde
make linters happy
c796ef3 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde
Copy link
Collaborator Author

ahcorde commented Jun 26, 2020

Related with this issue #89

chapulina
chapulina approved these changes Jul 1, 2020
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working for me, thanks! I just have some small comments below, we can merge once they're addressed.

ros_ign_gazebo_demos/launch/air_pressure.launch.py Outdated Show resolved Hide resolved
ros_ign_gazebo_demos/launch/depth_camera.launch.py Outdated Show resolved Hide resolved
ros_ign_gazebo_demos/launch/imu.launch.py Show resolved Hide resolved
ros_ign_gazebo_demos/launch/rgbd_camera.launch.py Outdated Show resolved Hide resolved
@ahcorde
Added feedback
948f060 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde merged commit e2feecf into ros2 Jul 2, 2020
Core development automation moved this from In review to Done Jul 2, 2020
@ahcorde ahcorde deleted the ahcorde/ros_ign_gazebo_demos branch July 2, 2020 06:42
@j-rivero j-rivero removed this from Done in Core development May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

Assignees

@ahcorde ahcorde

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ahcorde @chapulina