Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port ros_ign_bridge test to ROS 2 #98

Merged
merged 2 commits into from
Jul 25, 2020
Merged

Port ros_ign_bridge test to ROS 2 #98

merged 2 commits into from
Jul 25, 2020

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented Jul 23, 2020

Related with this issue #92

Signed-off-by: ahcorde ahcorde@gmail.com

@ahcorde ahcorde added the enhancement New feature or request label Jul 23, 2020
@ahcorde ahcorde requested a review from chapulina July 23, 2020 15:46
@ahcorde ahcorde self-assigned this Jul 23, 2020
@ahcorde ahcorde mentioned this pull request Jul 23, 2020
Closed
@osrf-triage osrf-triage added this to Inbox in Core development Jul 23, 2020
chapulina
chapulina suggested changes Jul 23, 2020
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is failing, I think you need to add some dependencies to package.xml.

ros_ign_bridge/test/publishers/ign_publisher.cpp Outdated Show resolved Hide resolved
ros_ign_bridge/test/publishers/ros_publisher.cpp Outdated Show resolved Hide resolved
ros_ign_bridge/test/subscribers/ign_subscriber.cpp Outdated Show resolved Hide resolved
ros_ign_bridge/test/subscribers/ign_subscriber.cpp Outdated Show resolved Hide resolved
ros_ign_bridge/test/subscribers/ros_subscriber.cpp Outdated Show resolved Hide resolved
ros_ign_bridge/test/test_utils.hpp Show resolved Hide resolved
ros_ign_bridge/CMakeLists.txt Outdated Show resolved Hide resolved
ros_ign_bridge/test/launch/test_ign_subscriber.launch.py Show resolved Hide resolved
Core development automation moved this from Inbox to In review Jul 23, 2020
@ahcorde ahcorde force-pushed the ahcorde/test/bridge branch 2 times, most recently from 73f8b84 to 9da3325 Compare July 24, 2020 08:59
@ahcorde ahcorde requested a review from chapulina July 24, 2020 10:02
chapulina
chapulina approved these changes Jul 25, 2020
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! We should eventually backport it to dashing too.

@ahcorde @chapulina
Rename test_utils.hpp (#98)
d5e2551 
Signed-off-by: ahcorde <ahcorde@gmail.com>
chapulina pushed a commit that referenced this pull request Jul 25, 2020
@ahcorde @chapulina
Port ros_ign_bridge tests to ROS 2 (#98)
33099b8 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde @chapulina
Port ros_ign_bridge tests to ROS 2 (#98)
5e343f2 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@chapulina chapulina merged commit 7cb676d into ros2 Jul 25, 2020
Core development automation moved this from In review to Done Jul 25, 2020
chapulina pushed a commit that referenced this pull request Jul 25, 2020
@ahcorde @chapulina
Rename test_utils.hpp (#98)
5cf197d 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@chapulina chapulina deleted the ahcorde/test/bridge branch July 25, 2020 01:51
ahcorde added a commit that referenced this pull request Jul 27, 2020
@ahcorde
Rename test_utils.hpp (#98)
ed76bfa 
Signed-off-by: ahcorde <ahcorde@gmail.com>
ahcorde added a commit that referenced this pull request Jul 27, 2020
@ahcorde
Port ros_ign_bridge tests to ROS 2 (#98)
4ea1609 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde mentioned this pull request Jul 27, 2020
Merged
chapulina pushed a commit that referenced this pull request Jul 27, 2020
@ahcorde @chapulina
Rename test_utils.hpp (#98)
cb0e341 
Signed-off-by: ahcorde <ahcorde@gmail.com>
chapulina pushed a commit that referenced this pull request Jul 27, 2020
@ahcorde @chapulina
Port ros_ign_bridge tests to ROS 2 (#98)
9fba047 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@j-rivero j-rivero removed this from Done in Core development May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

Assignees

@ahcorde ahcorde

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ahcorde @chapulina