Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port bridge tests to ROS 2 #92

Closed
chapulina opened this issue Jul 13, 2020 · 1 comment
Closed

Port bridge tests to ROS 2 #92

chapulina opened this issue Jul 13, 2020 · 1 comment
Assignees
@ahcorde
Labels
help wanted Extra attention is needed ROS 2 ROS 2 tests Broken or missing tests / testing infra

Comments

@chapulina
Copy link
Contributor

When we initially ported ros_ign_bridge from ROS 1 to ROS 2, there wasn't an easy way to port the tests yet (I believe there was no launch testing). Now that's already available, so we should enable tests for ROS 2:

https://github.com/ignitionrobotics/ros_ign/blob/e2feecf0cbba07a2f2b630c3dd42a674d251bc61/ros_ign_bridge/CMakeLists.txt#L111-L113
@chapulina chapulina added help wanted Extra attention is needed ROS 2 ROS 2 tests Broken or missing tests / testing infra labels Jul 13, 2020
@ahcorde ahcorde mentioned this issue Jul 23, 2020
Merged
@ahcorde
Copy link
Collaborator

ahcorde commented Jul 23, 2020

PR #98

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ahcorde ahcorde

Labels
help wanted Extra attention is needed ROS 2 ROS 2 tests Broken or missing tests / testing infra
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ahcorde @chapulina