Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure that ign_* yaml configs work as well #310

Merged
merged 3 commits into from Oct 12, 2022
Merged

Make sure that ign_* yaml configs work as well #310

merged 3 commits into from Oct 12, 2022

Conversation

mjcarroll
Copy link
Collaborator

馃 Bug fix

Potentially addresses #307

Summary

This adds support for configuration files with ign_ tags as well and prints deprecation warnings.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@mjcarroll
Make sure that ign_* yaml configs work as well
3889f52 
Signed-off-by: Michael Carroll <michael@openrobotics.org>
@osrf-triage osrf-triage added this to Inbox in Core development Oct 11, 2022
@mjcarroll mjcarroll mentioned this pull request Oct 11, 2022
Closed
@mjcarroll
Lint
24442d9 
Signed-off-by: Michael Carroll <michael@openrobotics.org>
@mjcarroll mjcarroll self-assigned this Oct 11, 2022
@mjcarroll mjcarroll moved this from Inbox to In review in Core development Oct 11, 2022
ahcorde
ahcorde requested changes Oct 11, 2022
View reviewed changes
ros_gz_bridge/src/bridge_config.cpp Show resolved Hide resolved
ros_gz_bridge/src/bridge_config.cpp Outdated Show resolved Hide resolved
@mjcarroll
Address reviewer feedback
6252d72 
Signed-off-by: Michael Carroll <michael@openrobotics.org>
@ahcorde ahcorde merged commit 3d0937a into humble Oct 12, 2022
Core development automation moved this from In review to Done Oct 12, 2022
@ahcorde ahcorde deleted the mjcarroll/ign_config branch October 12, 2022 09:07
@mjcarroll mjcarroll mentioned this pull request Oct 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

Assignees

@mjcarroll mjcarroll

Labels
None yet
Projects
Core development
Archived in project
Core development
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mjcarroll @ahcorde