Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ros_ign_bridge): exports dependencies to downstream packages #404

Conversation

Guillaumebeuzeboc
Copy link

馃 Bug fix

Summary

Exports dependencies of ros_ign_bridge to downstream packages. This way a package using ros_ign_bridge won't have to manually import its dependencies (nav_msgs for example)

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Signed-off-by: Guillaumebeuzeboc <guillaume.beuzeboc@gmail.com>
Core development automation moved this from Inbox to In review Jun 5, 2023
@ahcorde ahcorde merged commit e94d406 into gazebosim:foxy Jun 5, 2023
4 checks passed
Core development automation moved this from In review to Done Jun 5, 2023
@Guillaumebeuzeboc Guillaumebeuzeboc deleted the fix/ros_ign_bridge_not_exporting_deps branch June 5, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants