Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to change material color from ROS. #486

Merged
merged 21 commits into from
Feb 1, 2024
Merged
Show file tree
Hide file tree
Changes from 20 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ Galactic | Edifice | [galactic](https://github.com/gazebosim/ros_gz/tree/galacti
Galactic | Fortress | [galactic](https://github.com/gazebosim/ros_gz/tree/galactic) | only from source
Humble | Fortress | [humble](https://github.com/gazebosim/ros_gz/tree/humble) | https://packages.ros.org
Humble | Garden | [humble](https://github.com/gazebosim/ros_gz/tree/humble) | [gazebo packages](https://gazebosim.org/docs/latest/ros_installation#gazebo-garden-with-ros-2-humble-iron-or-rolling-use-with-caution-)[^1]
Humble | Harmonic | [humble](https://github.com/gazebosim/ros_gz/tree/humble) | only from source
Humble | Harmonic | [humble](https://github.com/gazebosim/ros_gz/tree/humble) | [gazebo packages](https://gazebosim.org/docs/harmonic/ros_installation#-gazebo-harmonic-with-ros-2-humble-iron-or-rolling-use-with-caution-)[^1]
Rolling | Edifice | [ros2](https://github.com/gazebosim/ros_gz/tree/ros2) | only from source
Rolling | Fortress | [ros2](https://github.com/gazebosim/ros_gz/tree/ros2) | https://packages.ros.org
Rolling | Garden | [ros2](https://github.com/gazebosim/ros_gz/tree/ros2) | only from source
Expand Down
19 changes: 19 additions & 0 deletions ros_gz_bridge/include/ros_gz_bridge/convert/ros_gz_interfaces.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,11 @@
#include <ros_gz_interfaces/msg/dataframe.hpp>
#endif // HAVE_DATAFRAME

#if HAVE_MATERIALCOLOR
#include <gz/msgs/material_color.pb.h>
#include <ros_gz_interfaces/msg/material_color.hpp>
#endif // HAVE_MATERIALCOLOR

#include <ros_gz_bridge/convert_decl.hpp>

namespace ros_gz_bridge
Expand Down Expand Up @@ -159,6 +164,20 @@ convert_gz_to_ros(
const gz::msgs::Light & gz_msg,
ros_gz_interfaces::msg::Light & ros_msg);

#if HAVE_MATERIALCOLOR
template<>
void
convert_ros_to_gz(
const ros_gz_interfaces::msg::MaterialColor & ros_msg,
gz::msgs::MaterialColor & gz_msg);

template<>
void
convert_gz_to_ros(
const gz::msgs::MaterialColor & gz_msg,
ros_gz_interfaces::msg::MaterialColor & ros_msg);
#endif // HAVE_MATERIALCOLOR

template<>
void
convert_ros_to_gz(
Expand Down
7 changes: 7 additions & 0 deletions ros_gz_bridge/include/ros_gz_bridge/ros_gz_bridge.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,13 @@
#define HAVE_DATAFRAME true
#endif

// MaterialColor is available from versions 10.1.0 (Harmonic) forward
// This can be removed when the minimum supported version passes 10.1.0
#if (GZ_MSGS_MAJOR_VERSION > 10) || \
((GZ_MSGS_MAJOR_VERSION == 10) && (GZ_MSGS_MINOR_VERSION >= 1))
#define HAVE_MATERIALCOLOR true
#endif

namespace ros_gz_bridge
{
/// Forward declarations
Expand Down
10 changes: 9 additions & 1 deletion ros_gz_bridge/ros_gz_bridge/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

import os

from ros_gz_bridge.mappings import MAPPINGS, MAPPINGS_8_4_0
from ros_gz_bridge.mappings import MAPPINGS, MAPPINGS_8_4_0, MAPPINGS_10_1_0

from rosidl_cmake import expand_template

Expand Down Expand Up @@ -75,6 +75,14 @@ def mappings(gz_msgs_ver):
ros2_message_name=mapping.ros_type,
gz_message_name=mapping.gz_type
))
if gz_msgs_ver >= (10, 1, 0):
for (ros2_package_name, mappings) in MAPPINGS_10_1_0.items():
for mapping in sorted(mappings):
data.append(MessageMapping(
ros2_package_name=ros2_package_name,
ros2_message_name=mapping.ros_type,
gz_message_name=mapping.gz_type
))
return sorted(data, key=lambda mm: mm.ros2_string())


Expand Down
6 changes: 6 additions & 0 deletions ros_gz_bridge/ros_gz_bridge/mappings.py
Original file line number Diff line number Diff line change
Expand Up @@ -114,3 +114,9 @@
Mapping('Dataframe', 'Dataframe'),
],
}

MAPPINGS_10_1_0 = {
'ros_gz_interfaces': [
Mapping('MaterialColor', 'MaterialColor'),
],
}
60 changes: 60 additions & 0 deletions ros_gz_bridge/src/convert/ros_gz_interfaces.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -380,6 +380,66 @@ convert_gz_to_ros(
ros_msg.intensity = gz_msg.intensity();
}

#if HAVE_MATERIALCOLOR
template<>
void
convert_ros_to_gz(
const ros_gz_interfaces::msg::MaterialColor & ros_msg,
gz::msgs::MaterialColor & gz_msg)
{
using EntityMatch = gz::msgs::MaterialColor::EntityMatch;

switch (ros_msg.entity_match) {
case ros_gz_interfaces::msg::MaterialColor::FIRST:
gz_msg.set_entity_match(EntityMatch::MaterialColor_EntityMatch_FIRST);
break;
case ros_gz_interfaces::msg::MaterialColor::ALL:
gz_msg.set_entity_match(EntityMatch::MaterialColor_EntityMatch_ALL);
break;
default:
std::cerr << "Unsupported entity match type ["
<< ros_msg.entity_match << "]\n";
}

convert_ros_to_gz(ros_msg.header, (*gz_msg.mutable_header()));
convert_ros_to_gz(ros_msg.entity, *gz_msg.mutable_entity());
convert_ros_to_gz(ros_msg.ambient, *gz_msg.mutable_ambient());
convert_ros_to_gz(ros_msg.diffuse, *gz_msg.mutable_diffuse());
convert_ros_to_gz(ros_msg.specular, *gz_msg.mutable_specular());
convert_ros_to_gz(ros_msg.emissive, *gz_msg.mutable_emissive());

gz_msg.set_shininess(ros_msg.shininess);
}

template<>
void
convert_gz_to_ros(
const gz::msgs::MaterialColor & gz_msg,
ros_gz_interfaces::msg::MaterialColor & ros_msg)
{
using EntityMatch = gz::msgs::MaterialColor::EntityMatch;
if (gz_msg.entity_match() == EntityMatch::MaterialColor_EntityMatch_FIRST) {
ros_msg.entity_match = ros_gz_interfaces::msg::MaterialColor::FIRST;
/* *INDENT-OFF* */
} else if (gz_msg.entity_match() ==
EntityMatch::MaterialColor_EntityMatch_ALL) {
/* *INDENT-ON* */
ros_msg.entity_match = ros_gz_interfaces::msg::MaterialColor::ALL;
} else {
std::cerr << "Unsupported EntityMatch [" <<
gz_msg.entity_match() << "]" << std::endl;
}
convert_gz_to_ros(gz_msg.header(), ros_msg.header);
convert_gz_to_ros(gz_msg.entity(), ros_msg.entity);
convert_gz_to_ros(gz_msg.ambient(), ros_msg.ambient);
convert_gz_to_ros(gz_msg.diffuse(), ros_msg.diffuse);
convert_gz_to_ros(gz_msg.specular(), ros_msg.specular);
convert_gz_to_ros(gz_msg.emissive(), ros_msg.emissive);

ros_msg.shininess = gz_msg.shininess();
}
#endif // HAVE_MATERIALCOLOR

template<>
void
convert_ros_to_gz(
Expand Down
31 changes: 31 additions & 0 deletions ros_gz_bridge/test/utils/gz_test_msg.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1346,6 +1346,37 @@ void compareTestMsg(const std::shared_ptr<gz::msgs::Light> & _msg)
EXPECT_FLOAT_EQ(expected_msg.intensity(), _msg->intensity());
}

#if HAVE_MATERIALCOLOR
void createTestMsg(gz::msgs::MaterialColor & _msg)
{
createTestMsg(*_msg.mutable_header());
createTestMsg(*_msg.mutable_entity());
createTestMsg(*_msg.mutable_ambient());
createTestMsg(*_msg.mutable_diffuse());
createTestMsg(*_msg.mutable_specular());
createTestMsg(*_msg.mutable_emissive());

_msg.set_shininess(1.0);
_msg.set_entity_match(gz::msgs::MaterialColor::EntityMatch::MaterialColor_EntityMatch_ALL);
}

void compareTestMsg(const std::shared_ptr<gz::msgs::MaterialColor> & _msg)
{
gz::msgs::MaterialColor expected_msg;
createTestMsg(expected_msg);

compareTestMsg(std::make_shared<gz::msgs::Header>(_msg->header()));
compareTestMsg(std::make_shared<gz::msgs::Entity>(_msg->entity()));
compareTestMsg(std::make_shared<gz::msgs::Color>(_msg->ambient()));
compareTestMsg(std::make_shared<gz::msgs::Color>(_msg->diffuse()));
compareTestMsg(std::make_shared<gz::msgs::Color>(_msg->specular()));
compareTestMsg(std::make_shared<gz::msgs::Color>(_msg->emissive()));

EXPECT_EQ(expected_msg.shininess(), _msg->shininess());
EXPECT_EQ(expected_msg.entity_match(), _msg->entity_match());
}
#endif // HAVE_MATERIALCOLOR

void createTestMsg(gz::msgs::GUICamera & _msg)
{
gz::msgs::Header header_msg;
Expand Down
14 changes: 14 additions & 0 deletions ros_gz_bridge/test/utils/gz_test_msg.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,10 @@
#include <gz/msgs/dataframe.pb.h>
#endif // HAVE_DATAFRAME

#if HAVE_MATERIALCOLOR
#include <gz/msgs/material_color.pb.h>
#endif // HAVE_MATERIALCOLOR

namespace ros_gz_bridge
{
namespace testing
Expand Down Expand Up @@ -455,6 +459,16 @@ void createTestMsg(gz::msgs::Light & _msg);
/// \param[in] _msg The message to compare.
void compareTestMsg(const std::shared_ptr<gz::msgs::Light> & _msg);

#if HAVE_MATERIALCOLOR
/// \brief Create a message used for testing.
/// \param[out] _msg The message populated.
void createTestMsg(gz::msgs::MaterialColor & _msg);

/// \brief Compare a message with the populated for testing.
/// \param[in] _msg The message to compare.
void compareTestMsg(const std::shared_ptr<gz::msgs::MaterialColor> & _msg);
#endif // HAVE_MATERIALCOLOR

/// \brief Create a message used for testing.
/// \param[out] _msg The message populated.
void createTestMsg(gz::msgs::GUICamera & _msg);
Expand Down
30 changes: 30 additions & 0 deletions ros_gz_bridge/test/utils/ros_test_msg.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -577,6 +577,36 @@ void compareTestMsg(const std::shared_ptr<ros_gz_interfaces::msg::Light> & _msg)
EXPECT_FLOAT_EQ(expected_msg.intensity, _msg->intensity);
}

#if HAVE_MATERIALCOLOR
void createTestMsg(ros_gz_interfaces::msg::MaterialColor & _msg)
{
createTestMsg(_msg.header);
createTestMsg(_msg.entity);
createTestMsg(_msg.ambient);
createTestMsg(_msg.diffuse);
createTestMsg(_msg.specular);
createTestMsg(_msg.emissive);
_msg.shininess = 1.0;
_msg.entity_match = ros_gz_interfaces::msg::MaterialColor::ALL;
}

void compareTestMsg(const std::shared_ptr<ros_gz_interfaces::msg::MaterialColor> & _msg)
{
ros_gz_interfaces::msg::MaterialColor expected_msg;
createTestMsg(expected_msg);

compareTestMsg(_msg->header);
compareTestMsg(std::make_shared<ros_gz_interfaces::msg::Entity>(_msg->entity));
compareTestMsg(std::make_shared<std_msgs::msg::ColorRGBA>(_msg->ambient));
compareTestMsg(std::make_shared<std_msgs::msg::ColorRGBA>(_msg->diffuse));
compareTestMsg(std::make_shared<std_msgs::msg::ColorRGBA>(_msg->specular));
compareTestMsg(std::make_shared<std_msgs::msg::ColorRGBA>(_msg->emissive));

EXPECT_EQ(expected_msg.shininess, _msg->shininess);
EXPECT_EQ(expected_msg.entity_match, _msg->entity_match);
}
#endif // HAVE_MATERIALCOLOR

void createTestMsg(ros_gz_interfaces::msg::GuiCamera & _msg)
{
createTestMsg(_msg.header);
Expand Down
13 changes: 13 additions & 0 deletions ros_gz_bridge/test/utils/ros_test_msg.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,9 @@
#include <ros_gz_interfaces/msg/dataframe.hpp>
#endif // HAVE_DATAFRAME
#include <ros_gz_interfaces/msg/light.hpp>
#if HAVE_MATERIALCOLOR
#include <ros_gz_interfaces/msg/material_color.hpp>
#endif // HAVE_MATERIALCOLOR
#include <ros_gz_interfaces/msg/param_vec.hpp>
#include <ros_gz_interfaces/msg/sensor_noise.hpp>
#include <ros_gz_interfaces/msg/string_vec.hpp>
Expand Down Expand Up @@ -385,6 +388,16 @@ void createTestMsg(ros_gz_interfaces::msg::Light & _msg);
/// \param[in] _msg The message to compare.
void compareTestMsg(const std::shared_ptr<ros_gz_interfaces::msg::Light> & _msg);

#if HAVE_MATERIALCOLOR
/// \brief Create a message used for testing.
/// \param[out] _msg The message populated.
void createTestMsg(ros_gz_interfaces::msg::MaterialColor & _msg);

/// \brief Compare a message with the populated for testing.
/// \param[in] _msg The message to compare.
void compareTestMsg(const std::shared_ptr<ros_gz_interfaces::msg::MaterialColor> & _msg);
#endif // HAVE_MATERIALCOLOR

/// \brief Create a message used for testing.
/// \param[out] _msg The message populated.
void createTestMsg(ros_gz_interfaces::msg::Entity & _msg);
Expand Down
1 change: 1 addition & 0 deletions ros_gz_interfaces/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ set(msg_files
"msg/GuiCamera.msg"
"msg/JointWrench.msg"
"msg/Light.msg"
"msg/MaterialColor.msg"
"msg/ParamVec.msg"
"msg/SensorNoise.msg"
"msg/StringVec.msg"
Expand Down
12 changes: 12 additions & 0 deletions ros_gz_interfaces/msg/MaterialColor.msg
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
# Entities that match to apply material color: constant definition
uint8 FIRST = 0
uint8 ALL = 1

std_msgs/Header header # Optional header data
ros_gz_interfaces/Entity entity # Entity to change material color
std_msgs/ColorRGBA ambient # Ambient color
std_msgs/ColorRGBA diffuse # Diffuse color
std_msgs/ColorRGBA specular # Specular color
std_msgs/ColorRGBA emissive # Emissive color
float64 shininess # Specular exponent
uint8 entity_match # Entities that match to apply material color
Loading