[backport Iron] Create bridge for GPSFix msg (#316) #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vincent Rousseau <vincent.rousseau@sabi-agri.com>
caguero
reviewed
Apr 15, 2024
| ros_msg.track = atan2(gz_msg.velocity_north(), gz_msg.velocity_east()); | ||
| ros_msg.climb = gz_msg.velocity_up(); | ||
|
|
||
| // position_covariance is not supported in Ignition::Msgs::NavSat. |
ros_gz_bridge/README.md
Outdated
| @@ -31,6 +31,7 @@ The following message types can be bridged for topics: | |||
| | geometry_msgs/msg/Twist | ignition::msgs::Twist | | |||
| | geometry_msgs/msg/TwistStamped | ignition::msgs::Twist | | |||
| | geometry_msgs/msg/TwistWithCovariance| ignition::msgs::TwistWithCovariance | | |||
| | gps_msgs/GPSFix | ignition.msgs.NavSat | | |||
There was a problem hiding this comment.
Should we update the README and replace ignition with gz?
There was a problem hiding this comment.
Since humble and iron officially support Fortress, we've been keeping the ignition name here. The formatting needs to be fixed though. :: instead of ..
9 tasks
caguero
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃帀 New feature
Summary
Related with this PR #316
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.