dashing ➡️ ros2

ros_ign_bridge/CMakeLists.txt

@@ -38,8 +38,8 @@ endif()
 include_directories(include)
 
 set(common_sources
-  src/convert_builtin_interfaces.cpp
-  src/builtin_interfaces_factories.cpp
+  src/convert.cpp
+  src/factories.cpp
 )
 
 set(bridge_executables

ros_ign_bridge/include/ros_ign_bridge/convert_builtin_interfaces.hpp → ros_ign_bridge/include/ros_ign_bridge/convert.hpp

@@ -12,12 +12,12 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#ifndef ROS_IGN_BRIDGE__CONVERT_BUILTIN_INTERFACES_HPP_
-#define ROS_IGN_BRIDGE__CONVERT_BUILTIN_INTERFACES_HPP_
+#ifndef ROS_IGN_BRIDGE__CONVERT_HPP_
+#define ROS_IGN_BRIDGE__CONVERT_HPP_
 
 #include <rclcpp/time.hpp>
 
-// include ROS 2 builtin messages
+// ROS 2 messages
 #include <geometry_msgs/msg/point.hpp>
 #include <geometry_msgs/msg/pose.hpp>
 #include <geometry_msgs/msg/pose_stamped.hpp>
@@ -42,7 +42,7 @@
 #include <std_msgs/msg/int32.hpp>
 #include <std_msgs/msg/string.hpp>
 
-// include Ignition builtin messages
+// Ignition messages
 #include <ignition/msgs.hh>
 
 #include <ros_ign_bridge/convert_decl.hpp>
@@ -372,4 +372,4 @@ convert_ign_to_ros(
 
 }  // namespace ros_ign_bridge
 
-#endif  // ROS_IGN_BRIDGE__CONVERT_BUILTIN_INTERFACES_HPP_
+#endif  // ROS_IGN_BRIDGE__CONVERT_HPP_

ros_ign_bridge/include/ros_ign_bridge/bridge.hpp → ros_ign_bridge/src/bridge.hpp

@@ -12,17 +12,17 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#ifndef ROS_IGN_BRIDGE__BRIDGE_HPP_
-#define ROS_IGN_BRIDGE__BRIDGE_HPP_
+#ifndef BRIDGE_HPP_
+#define BRIDGE_HPP_
 
 // include Ignition Transport
 #include <ignition/transport/Node.hh>
 
-#include <ros_ign_bridge/builtin_interfaces_factories.hpp>
-
 #include <memory>
 #include <string>
 
+#include "factories.hpp"
+
 namespace ros_ign_bridge
 {
 
@@ -110,4 +110,4 @@ create_bidirectional_bridge(
 
 }  // namespace ros_ign_bridge
 
-#endif  // ROS_IGN_BRIDGE__BRIDGE_HPP_
+#endif  // BRIDGE_HPP_

ros_ign_bridge/src/convert_builtin_interfaces.cpp → ros_ign_bridge/src/convert.cpp

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#include <ros_ign_bridge/convert_builtin_interfaces.hpp>
+#include "ros_ign_bridge/convert.hpp"
 
 #include <limits>
 #include <string>

ros_ign_bridge/src/builtin_interfaces_factories.cpp → ros_ign_bridge/src/factories.cpp

@@ -15,15 +15,14 @@
 #include <memory>
 #include <string>
 
-// include builtin interfaces
-#include "ros_ign_bridge/builtin_interfaces_factories.hpp"
-#include "ros_ign_bridge/convert_builtin_interfaces.hpp"
+#include "factories.hpp"
+#include "ros_ign_bridge/convert.hpp"
 
 namespace ros_ign_bridge
 {
 
 std::shared_ptr<FactoryInterface>
-get_factory_builtin_interfaces(
+get_factory_impl(
   const std::string & ros_type_name,
   const std::string & ign_type_name)
 {
@@ -299,7 +298,7 @@ get_factory(
   const std::string & ign_type_name)
 {
   std::shared_ptr<FactoryInterface> factory;
-  factory = get_factory_builtin_interfaces(ros_type_name, ign_type_name);
+  factory = get_factory_impl(ros_type_name, ign_type_name);
   if (factory) {
     return factory;
   }

ros_ign_bridge/include/ros_ign_bridge/builtin_interfaces_factories.hpp → ros_ign_bridge/src/factories.hpp

@@ -12,10 +12,10 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#ifndef ROS_IGN_BRIDGE__BUILTIN_INTERFACES_FACTORIES_HPP_
-#define ROS_IGN_BRIDGE__BUILTIN_INTERFACES_FACTORIES_HPP_
+#ifndef FACTORIES_HPP_
+#define FACTORIES_HPP_
 
-// include ROS 2 messages
+// ROS 2 messages
 #include <geometry_msgs/msg/point.hpp>
 #include <geometry_msgs/msg/pose.hpp>
 #include <geometry_msgs/msg/pose_stamped.hpp>
@@ -40,22 +40,16 @@
 #include <std_msgs/msg/int32.hpp>
 #include <std_msgs/msg/string.hpp>
 
-// include Ignition Transport messages
+// Ignition messages
 #include <ignition/msgs.hh>
 
-#include <ros_ign_bridge/factory.hpp>
-
 #include <memory>
 #include <string>
 
+#include "factory.hpp"
+
 namespace ros_ign_bridge
 {
-
-std::shared_ptr<FactoryInterface>
-get_factory_builtin_interfaces(
-  const std::string & ros_type_name,
-  const std::string & ign_type_name);
-
 std::shared_ptr<FactoryInterface>
 get_factory(
   const std::string & ros_type_name,
@@ -541,4 +535,4 @@ Factory<
 
 }  // namespace ros_ign_bridge
 
-#endif  // ROS_IGN_BRIDGE__BUILTIN_INTERFACES_FACTORIES_HPP_
+#endif  // FACTORIES_HPP_

ros_ign_bridge/include/ros_ign_bridge/factory.hpp → ros_ign_bridge/src/factory.hpp

@@ -12,8 +12,8 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#ifndef ROS_IGN_BRIDGE__FACTORY_HPP_
-#define ROS_IGN_BRIDGE__FACTORY_HPP_
+#ifndef FACTORY_HPP_
+#define FACTORY_HPP_
 
 #include <ignition/transport/Node.hh>
 
@@ -24,7 +24,7 @@
 #include <memory>
 #include <string>
 
-#include "ros_ign_bridge/factory_interface.hpp"
+#include "factory_interface.hpp"
 
 namespace ros_ign_bridge
 {
@@ -150,4 +150,4 @@ class Factory : public FactoryInterface
 
 }  // namespace ros_ign_bridge
 
-#endif  // ROS_IGN_BRIDGE__FACTORY_HPP_
+#endif  // FACTORY_HPP_

ros_ign_bridge/include/ros_ign_bridge/factory_interface.hpp → ros_ign_bridge/src/factory_interface.hpp

@@ -12,8 +12,8 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#ifndef  ROS_IGN_BRIDGE__FACTORY_INTERFACE_HPP_
-#define  ROS_IGN_BRIDGE__FACTORY_INTERFACE_HPP_
+#ifndef  FACTORY_INTERFACE_HPP_
+#define  FACTORY_INTERFACE_HPP_
 
 // include ROS 2
 #include <rclcpp/rclcpp.hpp>
@@ -63,4 +63,4 @@ class FactoryInterface
 
 }  // namespace ros_ign_bridge
 
-#endif  // ROS_IGN_BRIDGE__FACTORY_INTERFACE_HPP_
+#endif  // FACTORY_INTERFACE_HPP_

ros_ign_bridge/src/parameter_bridge.cpp

@@ -18,14 +18,14 @@
 // include Ignition Transport
 #include <ignition/transport/Node.hh>
 
-#include <ros_ign_bridge/bridge.hpp>
-
 #include <iostream>
 #include <list>
 #include <memory>
 #include <string>
 #include <vector>
 
+#include "bridge.hpp"
+
 // Direction of bridge.
 enum Direction
 {

ros_ign_bridge/src/static_bridge.cpp

@@ -17,11 +17,11 @@
 // include Ignition Transport
 #include <ignition/transport/Node.hh>
 
-#include <ros_ign_bridge/bridge.hpp>
-
 #include <memory>
 #include <string>
 
+#include "bridge.hpp"
+
 //////////////////////////////////////////////////
 int main(int argc, char * argv[])
 {

ros_ign_image/src/image_bridge.cpp

@@ -16,7 +16,7 @@
 
 #include <rclcpp/rclcpp.hpp>
 #include <image_transport/image_transport.h>
-#include <ros_ign_bridge/convert_builtin_interfaces.hpp>
+#include <ros_ign_bridge/convert.hpp>
 
 #include <iostream>
 #include <memory>