Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ign -> gz CLI Migration : sdformat #1047

Merged
merged 2 commits into from
Jun 22, 2022
Merged

ign -> gz CLI Migration : sdformat #1047

merged 2 commits into from
Jun 22, 2022

Conversation

methylDragon
Copy link
Contributor

@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jun 12, 2022
@osrf-triage osrf-triage added this to Inbox in Core development Jun 12, 2022
@methylDragon methylDragon marked this pull request as ready for review June 13, 2022 05:37
@methylDragon
Copy link
Contributor Author

methylDragon commented Jun 13, 2022

Pretty sure the sdf_description make target isn't being configured because:

find_program(GZ_PROGRAM gz)

and

if (GZ_PROGRAM)

  # Update this list as new sdformat spec versions are added.
  set(sdf_desc_versions 1.4 1.5 1.6 1.7 1.8 1.9)

  set(description_targets)
  foreach(desc_ver ${sdf_desc_versions})
    string(REPLACE "." "-" desc_ver_dash ${desc_ver})
    list(APPEND description_targets ${CMAKE_CURRENT_BINARY_DIR}/full_${desc_ver_dash}.sdf)
    add_custom_command(
      OUTPUT ${CMAKE_CURRENT_BINARY_DIR}/full_${desc_ver_dash}.sdf
      COMMAND
        ${CMAKE_COMMAND} -E env GZ_CONFIG_PATH=${CMAKE_BINARY_DIR}/test/conf
        ${GZ_PROGRAM}
      ARGS sdf -d ${desc_ver} > ${CMAKE_CURRENT_BINARY_DIR}/full_${desc_ver_dash}.sdf
      COMMENT "Generating full description for spec ${desc_ver}"
      VERBATIM)
  endforeach()
  add_custom_target(sdf_descriptions DEPENDS ${description_targets} ${PROJECT_LIBRARY_TARGET_NAME})
endif()

So we need the merge AND release of tools first. gz isn't going to be found otherwise.

@methylDragon methylDragon added the needs upstream release Blocked by a release of an upstream library label Jun 13, 2022
@chapulina chapulina added the ign to gz Renaming Ignition to Gazebo. label Jun 13, 2022
@chapulina chapulina moved this from Inbox to In review in Core development Jun 13, 2022
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
@codecov
Copy link

codecov bot commented Jun 22, 2022

Codecov Report

Merging #1047 (ba335c8) into main (8061156) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1047   +/-   ##
=======================================
  Coverage   83.42%   83.42%           
=======================================
  Files         149      149           
  Lines       18445    18445           
=======================================
  Hits        15388    15388           
  Misses       3057     3057           
Impacted Files Coverage Δ
src/Param.cc 87.78% <ø> (ø)
src/gz.cc 81.29% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8061156...ba335c8. Read the comment docs.

@chapulina chapulina removed the needs upstream release Blocked by a release of an upstream library label Jun 22, 2022
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UNIT_gz_TEST passed on Linux and macOS! 🚀

@chapulina chapulina merged commit 15718e8 into main Jun 22, 2022
@chapulina chapulina deleted the cli_migration branch June 22, 2022 21:43
Core development automation moved this from In review to Done Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden ign to gz Renaming Ignition to Gazebo.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants