Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Root::WorldByName #1121

Merged
merged 5 commits into from
Oct 20, 2022
Merged

Added Root::WorldByName #1121

merged 5 commits into from
Oct 20, 2022

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Aug 30, 2022

Signed-off-by: Nate Koenig nate@openrobotics.org

🎉 New feature

Summary

Adds "Root::WorldByName". Needed by gazebosim/gz-sim#1669

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Nate Koenig <nate@openrobotics.org>
@codecov
Copy link

codecov bot commented Aug 30, 2022

Codecov Report

Merging #1121 (530cf24) into sdf13 (c703dee) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##            sdf13    #1121   +/-   ##
=======================================
  Coverage   87.26%   87.26%           
=======================================
  Files         125      125           
  Lines       16111    16118    +7     
=======================================
+ Hits        14059    14066    +7     
  Misses       2052     2052           
Impacted Files Coverage Δ
src/Root.cc 95.19% <100.00%> (+0.15%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Core development automation moved this from Inbox to In review Aug 30, 2022
@chapulina chapulina added the enhancement New feature or request label Aug 30, 2022
@scpeters scpeters merged commit 5558b7c into sdf13 Oct 20, 2022
Core development automation moved this from In review to Done Oct 20, 2022
@scpeters scpeters deleted the root_world_by_name branch October 20, 2022 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request 🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants