-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport the python3 embedSdf script variant #1240
Conversation
These won't be used as part of the cmake build on this branch, but are useful for generating the same file from bazel. Co-authored-by: Bi0T1N <Bi0T1N@users.noreply.github.com> Co-authored-by: Michael Carroll <michael@openrobotics.org> Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm hoping CI is only failing because of the .py
->.rb
typo.
Signed-off-by: Michael Carroll <michael@openrobotics.org> Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## sdf13 #1240 +/- ##
==========================================
+ Coverage 87.49% 87.51% +0.01%
==========================================
Files 126 126
Lines 16239 16239
==========================================
+ Hits 14209 14211 +2
+ Misses 2030 2028 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@osrf-jenkins retest this please |
sdf/embedSdf.py
Outdated
files = [] | ||
for path in arg_pathlist: | ||
# dir separator is hardcoded to '/' in C++ mapping | ||
posix_path = PurePosixPath(path) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we've seen regressions on windows when porting this forward in #1297 (review)
I think we need to keep the PurePosixPath
call
This backports the
embedSdf.py
script from #884 and adds some improvements to make it usable in support of the sdformat bazel build.This does not make sdf13 use the embedSdf script by default, instead still preferring the ruby version.