-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for no gravity link #1410
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## sdf12 #1410 +/- ##
==========================================
+ Coverage 92.14% 92.16% +0.02%
==========================================
Files 79 79
Lines 13126 13267 +141
==========================================
+ Hits 12095 12228 +133
- Misses 1031 1039 +8 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mind to update the Python binding too ?
Signed-off-by: youhy <haoyuan2019@outlook.com>
52f1d2e
to
a6fd3e2
Compare
Signed-off-by: youhy <haoyuan2019@outlook.com>
Sure I'd love to but how do I do that? I looked around but didn't find any docs/codes for this. Can you tell me where I should start? |
There are two files that you need to modify:
|
These 2 files are only available for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: youhy <haoyuan2019@outlook.com>
@scpeters I can see this error on macOS
|
friendly ping @scpeters |
#1367 needs to be backported to Fortress. I'll go ahead and merge this since the Jenkins macOS build is green. |
🎉 New feature
Original issue: gazebosim/gz-sim#504
Summary
Add parsing and support for no gravity link when using DartSim engine
For implementation and test details, see gazebosim/gz-sim#2398
Changes in other repo:
gz-physics: gazebosim/gz-physics#633
sdformat: #1410
Test it
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.