Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python binding for no gravity link #1419

Merged
merged 2 commits into from
May 30, 2024

Conversation

AzulRadio
Copy link
Contributor

🎉 New feature

Closes #1416

Summary

Add python binding for no gravity link. See #1410 and comment #1410 (comment)

Test it

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: youhy <haoyuan2019@outlook.com>
@AzulRadio AzulRadio added the needs upstream release Blocked by a release of an upstream library label May 16, 2024
@github-actions github-actions bot added the 🌱 garden Ignition Garden label May 16, 2024
Copy link
Collaborator

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR requires two steps:

@iche033
Copy link
Contributor

iche033 commented May 30, 2024

Create a forward port from sdf12 to sdf13

#1426

@AzulRadio AzulRadio merged commit 7ac3696 into gazebosim:sdf13 May 30, 2024
9 checks passed
@AzulRadio AzulRadio deleted the azulradio/pythonbind branch May 30, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden needs upstream release Blocked by a release of an upstream library
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants