Fix bug where included URDFs are not parsed when there are no custom parsers #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…parsers Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
mjcarroll
approved these changes
May 5, 2021
nkoenig
removed this from Done
in SDFormat Development TRI (Moved to https://github.com/orgs/ignitionrobotics/projects/6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
#475 introduced a regression where included URDFs were being silently ignored when there are no custom parsers available. This returns the behavior back to URDFs being parsed natively by SDFormat if there are no custom parsers.
Note, however, that if there are custom parsers, but none of them are able to parse the URDF, the URDF file will be ignored. This might not be desirable, but changing the logic so that URDFs get parsed by SDFormat after trying all available custom parsers will require more significant changes, so I did not attempt to do that in this PR.
Checklist
sh tools/code_check.sh)test coverage)
another open pull request
to support the maintainers
Note to maintainers: Remember to use Squash-Merge