-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API changes for PrintConfig #708
Conversation
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should also add it to sdf::SDF::PrintValues
and sdf::SDF::ToString
. The implementation in #689 takes a string for sdf::SDF::PrintValues
, but IMO we would be more consistent and have better separation of concerns if it takes sdf::PrintConfig
instead. Then the code in ign.cc
can parse the command line arguments create the sdf::PrintConfig
object and pass it to sdf::SDF::PrintValues()
.
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
Done 7810a1b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the quick iteration.
Summary
Added API changes related to
PrintConfig
for #689Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge