Handle __model__ in joint parent or child when using merge-include #835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
azeey
added this to In progress
in SDFormat Development TRI (Moved to https://github.com/orgs/gazebosim/projects/2)
via automation
Codecov Report
@@ Coverage Diff @@
## sdf12 #835 +/- ##
=======================================
Coverage 90.70% 90.71%
=======================================
Files 78 78
Lines 12441 12447 +6
=======================================
+ Hits 11285 11291 +6
Misses 1156 1156
Continue to review full report at Codecov.
|
azeey
moved this from In progress
to In Review
in SDFormat Development TRI (Moved to https://github.com/orgs/gazebosim/projects/2)
scpeters
approved these changes
Jan 28, 2022
SDFormat Development TRI (Moved to https://github.com/orgs/gazebosim/projects/2)
automation
moved this from In Review
to Done
Jan 28, 2022
|
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-04-13-fortress-edifice/1367/1 |
j-rivero
removed this from Done
in SDFormat Development TRI (Moved to https://github.com/orgs/gazebosim/projects/2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
With #833 allowed using
__model__in//joint/parentor//joint/child. When merge-including models that include such cases, the__model__has to be changed to the proxy frame.Checklist
[ ] Updated documentation (as needed)[ ] Updated migration guide (as needed)codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.