Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added __copy__ and __deepcopy__ to Error and ParserConfig #953

Merged
merged 3 commits into from
Apr 8, 2022

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented Apr 7, 2022

Signed-off-by: ahcorde ahcorde@gmail.com

🦟 Bug fix

Fixes #

Summary

For consistency we are going to add __copy__ and __deepcopy__ to Error and ParserConfig class

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde added the scripting Scripting interfaces to Ignition label Apr 7, 2022
@ahcorde ahcorde self-assigned this Apr 7, 2022
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Apr 7, 2022
@osrf-triage osrf-triage added this to Inbox in Core development Apr 7, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 7, 2022

Codecov Report

Merging #953 (d60b43f) into main (ffdb8a6) will decrease coverage by 0.01%.
The diff coverage is 73.33%.

@@            Coverage Diff             @@
##             main     #953      +/-   ##
==========================================
- Coverage   88.06%   88.04%   -0.02%     
==========================================
  Files         105      105              
  Lines       14782    14794      +12     
==========================================
+ Hits        13018    13026       +8     
- Misses       1764     1768       +4     
Impacted Files Coverage Δ
python/src/sdf/pyParserConfig.cc 62.79% <71.42%> (+0.62%) ⬆️
python/src/sdf/pyError.cc 80.28% <75.00%> (-1.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffdb8a6...d60b43f. Read the comment docs.

@chapulina chapulina moved this from Inbox to In review in Core development Apr 7, 2022
python/src/sdf/pyError.cc Outdated Show resolved Hide resolved
python/test/pyError_TEST.py Show resolved Hide resolved
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde enabled auto-merge (squash) April 8, 2022 07:52
@ahcorde ahcorde merged commit 0bea6f9 into main Apr 8, 2022
Core development automation moved this from In review to Done Apr 8, 2022
@ahcorde ahcorde deleted the ahcorde/python/error_parserconfig_copy branch April 8, 2022 08:30
@j-rivero j-rivero removed this from Done in Core development May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden mujoco scripting Scripting interfaces to Ignition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants