Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDF to USD: Added Material Physics #975

Merged
merged 12 commits into from
May 5, 2022
Merged

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented Apr 13, 2022

Signed-off-by: Alejandro Hernández ahcorde@gmail.com

🎉 New feature

Requires:

Summary

friction parameters are expressed as a material in USD, this code will link the collision with the physics material

Test it

Example inside ign-gazebo

sdf2usd diff_drive_skid.sdf

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>
@ahcorde ahcorde added the usd label Apr 13, 2022
@ahcorde ahcorde requested a review from adlarkin April 13, 2022 14:10
@ahcorde ahcorde self-assigned this Apr 13, 2022
@osrf-triage osrf-triage added this to Inbox in Core development Apr 13, 2022
Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>
Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>
@chapulina chapulina moved this from Inbox to In review in Core development Apr 13, 2022
Base automatically changed from ahcorde/friction_ode to sdf12 April 14, 2022 06:45
@codecov-commenter
Copy link

codecov-commenter commented Apr 14, 2022

Codecov Report

Merging #975 (f16f8b0) into sdf12 (12e7782) will not change coverage.
The diff coverage is n/a.

❗ Current head f16f8b0 differs from pull request most recent head d065641. Consider uploading reports for the commit d065641 to get more accurate results

@@           Coverage Diff           @@
##            sdf12     #975   +/-   ##
=======================================
  Coverage   65.38%   65.38%           
=======================================
  Files           2        2           
  Lines          26       26           
=======================================
  Hits           17       17           
  Misses          9        9           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12e7782...d065641. Read the comment docs.

Signed-off-by: Ashton Larkin <42042756+adlarkin@users.noreply.github.com>
Signed-off-by: Ashton Larkin <42042756+adlarkin@users.noreply.github.com>
@chapulina
Copy link
Contributor

@ahcorde , is this ready to be merged?

@ahcorde ahcorde enabled auto-merge (squash) May 4, 2022 10:49
@azeey azeey disabled auto-merge May 5, 2022 03:55
@azeey azeey merged commit e18448e into sdf12 May 5, 2022
@azeey azeey deleted the ahcorde/sdf_to_usd_material_physics branch May 5, 2022 03:56
Core development automation moved this from In review to Done May 5, 2022
@j-rivero j-rivero removed this from Done in Core development May 6, 2022
@chapulina chapulina added this to Inbox in Core development via automation May 9, 2022
@chapulina chapulina moved this from Inbox to Done in Core development May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants